update rubocop to a current version about puppet-module-gems HOT 7 CLOSED

0.50 requires ruby >= 2.3 which breaks support

from puppet-module-gems.

Are there still supported versions with ruby < 2.3? It looks to me like there is not, based on https://puppet.com/docs/pe/latest/component_versions_in_recent_pe_releases.html

from puppet-module-gems.

current puppet uses ruby version 2.5.7
rubocop will not work with this version without disabling ruby version flags.

puppet --version
6.14.0

/opt/puppetlabs/puppet/bin/ruby -v
ruby 2.5.7p206 (2019-10-01 revision 67816) [x86_64-linux]

bundle exec rubocop --version
0.49.1

running rubocop the pdk way (gitlab ci rubocop)

bundle exec rake rubocop
Known versions: 1.9, 2.0, 2.1, 2.2, 2.3, 2.4

can we get it upgraded now?

from puppet-module-gems.

Updating rubocop will require a coordinated upgrade path to update the profiles defined in pdk-templates in all modules with minimal disturbance.

from puppet-module-gems.

I came to create this very same issue but saw that it was already open.

I had a what I thought was a very safe assumption that gem 'puppet-module-posix-dev-r2.6' would be able to use a modern version of Rubocop:

from puppet-module-gems.

I think the only way to do this because rubocop has many changes for each version is to keep a separate template based on ruby version.

So the puppet-module-gems version would be able to pick the correct rubycop.yml template per ruby. Additionally, we can use the mry tool to easily upgrade rubocop changes.

from puppet-module-gems.

This has been addressed in #156 and will be released later today as 1.0.0, with an accompanying change to pdk-templates

from puppet-module-gems.