Performance issue with the way cell height is determined about objc-timessquare HOT 4 CLOSED

Just as a data point, I set my first date and last date to a year before and year after the current date, respectively.

from objc-timessquare.

Indeed, this is a serious performance issue, and the time required to display the calendar is proportional to the number of months displayed, since every cell must be created before anything is displayed.

I fixed this problem by adding a +rowHeight class method to TSQCalendarCell, which is overridden in subclasses. Then I changed TSQCalendarView's -tableView:heightForRowAtIndexPath: method to ask the cell's class for the rowHeight, instead of instantiating a cell instance:

- (CGFloat)tableView:(UITableView *)tableView heightForRowAtIndexPath:(NSIndexPath *)indexPath;
{
    return [[self cellClassForRowAtIndexPath: indexPath] cellHeight];
}

- (Class) cellClassForRowAtIndexPath:(NSIndexPath *)indexPath;
{
    if (indexPath.row == 0 && !self.pinsHeaderToTop) {
        return [self headerCellClass];
    } else {
        return [self rowCellClass];
    }
}

After making these changes, performance has improved significantly, and the time to display the calendar is constant, no matter how many months are displayed, since now only the visible cells are created.

from objc-timessquare.

any chance this will get merged into master?

from objc-timessquare.

Thanks again for filing this. More words on performance: http://corner.squareup.com/2013/03/times-square-2.html

from objc-timessquare.