create_table with custome id and type problem about dataset HOT 4 CLOSED

I searched online and found the reason. http://stackoverflow.com/questions/1827063/mysql-error-key-specification-without-a-key-length

It seems that MySQL doesn't accept Text as primary key. If we still want to use Text as the primary key, the solution is to use VARCHAR type and place a limit of length on it.

Should dataset add support of VARCHAR type for MySQL?

from dataset.

in #27, String was added as one of the primary_type in create_table function, then it was changed to Text.

I am wondering if we can change Text back to String and modify create_table function as following,

if primary_type == 'Integer':
    # col = Column(primary_id, Integer, primary_key=True, autoincrement=auto_flag)
elif primary_type == 'String':
    # col = Column(primary_id, String, primary_key=True)
elif primary_type matches 'String\(\d+\)':
    # col = Column(primary_id, String(length), primary_key=True)
else:
    raise DatasetException("The primary_type has to be either 'Integer' or 'String'.") 

Thus, we can fix this bug that cannot create table with Text type in MySQL.

from dataset.

Do you want to make a pull request to that effect? I don't think there would be any problem with it...

from dataset.

yeah, I think we can use regex to match Integer|String(\(\d+\))? pattern.

I will make a pull request.

from dataset.