Let `upsert` return the ID of the row added / updated. about dataset HOT 2 CLOSED

Cool idea. The problem with this is that upsert can update multiple rows at once if the update criteria are open enough. So there would need to be handling for that case. Still, want to give it a shot?

from dataset.

I just give it a very quick look. Seems that:

• INSERT returns the PK of the row added.
• UPDATE returns True if any rows where updated, else False.
• UPSERT returns nothing.

So a consistent solution might be to return the ID on INSERT or a single UPDATE, True on multiple updates and False otherwise (on error). This also avoids the problem of having to guess if the return value is a ID or the numbers of rows changed.

As a side note:

try:
  # update code
  return rp.rowcount > 0
except KeyError:
  return False

Why not:

try:
  # update code
  return rp.rowcount
except KeyError:
  return 0

It seems to me we just loose information on the 1st version.
And the 2nd version still works fine in a simple if check.

But in the upsert function the casting done in the 1st version would be necessary.

This could look kinda like this: brutus@044dcce
Just a quick try in the on site editor. Couldn't test it from here.

from dataset.