Code Monkey home page Code Monkey logo

Comments (6)

geremyCohen avatar geremyCohen commented on August 20, 2024

https://github.com/pubnub/objective-c/tree/master/iOS#logging

#define PNLOG_LOGGING_ENABLED 1

I will add an explicit line to the docs to be sure there is no confusion moving forward.

from objective-c.

nimast avatar nimast commented on August 20, 2024

Should i actually change the header file? i've been trying to redefine / undefine this flag without success, yet i'm not sure i'm doing it properly as i don't have a strong c/cpp background. Appreciate your help!

from objective-c.

geremyCohen avatar geremyCohen commented on August 20, 2024

@nimast no problem, we're here to help. Just open PubNub/Misc/PNMacro.h and search for the line

#define PNLOG_LOGGING_ENABLED 1

And change the 1 to a 0, then recompile. Let me know if that helps you.

from objective-c.

nimast avatar nimast commented on August 20, 2024

I was hoping for a way to do this without touching pubnub's code, as our team is using CocoaPods and follows a best practise of leaving the Pods project's sources out of version control. This way every developer runs pods install by that ensuring dependencies have been met. Unfortunately (in this case), this also means that we often get all of our Pods source files overwritten by the original sources. As a result, in order to turn off this flag in pubnub's sources i'd have to fork the repo and create another podspec / point to that repository on my Podfile, and will need to manually keep it up to date by pulling from this one, which is a little on the hight side of maintenance for turning off a flag..

Though totally workaroundable, it will be really nice to see some other option for doing this without changing the sources (maybe as part of initialization / configuration?) in some future release.

At any case, setting this value to 0 works perfectly.

Thanks a lot!

from objective-c.

geremyCohen avatar geremyCohen commented on August 20, 2024

@nimast we'll be adding a fully configurable logger by 3.5.4, if not sooner. Sorry for the inconvenience in the meantime, but we're definitely addressing this as a top priority!

from objective-c.

parfeon avatar parfeon commented on August 20, 2024

Hi @nimast
Actually logging should be disabled by default and because of mistake it has been lefty turned on.
Those logging mostly created for debugging in case of any issues to help us discover why you have some troubles.

from objective-c.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.