search page returns original wiki page title about plots2 HOT 7 CLOSED

That's right -- but which page, exactly? The only place I could find that this happened was on the advanced search page at https://publiclab.org/search/advanced

The code for that is here: https://github.com/publiclab/plots2/blob/master/app/views/search/advanced.html.erb#L43

and indeed, it's using node.title. Should be an easy fix! Bryan, would you mind if I reformatted this to follow the basic format of this issue: #247 and then tagged it with first-timers-only?

from plots2.

@jywarren Does this issue needs a fix? Or will it be kept as a first-timer-only bug? The autocomplete results also show the old title. So we need a match.latest.title in the search controller. Well this indeed is an easy fix.

from plots2.

I think that this might be addressed by the new search interface, and in
the meantime, I'd like to leave the first-timers-only issues open, as they
take some work to prepare. If you're looking for something to do, maybe
give a try making a first-timers-only issue -- it's challenging, but can
really help recruit contributors!

On Thu, Jun 9, 2016 at 4:30 PM, Ananya Maiti [email protected]
wrote:

@jywarren https://github.com/jywarren Does this issue needs a fix? Or
will it be kept as a first-timer-only bug? The autocomplete results also
show the old title. So we need a match.latest.title in the search
controller. Well this indeed is an easy fix.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#7 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AABfJ0z6W41QuHPAm-BihNumkxmHZhRuks5qKHgCgaJpZM4BKlh9
.

from plots2.

Ok I will then try converting this as a first-timer issue by adding more content here.You can then label it as a first timer issue.

from plots2.

great, ping me when you do and I can delete extra comments too -- and/or
you can open a new issue, close this one linking to the new cleaner one if
you like.

On Mon, Jun 13, 2016 at 1:10 PM, Ananya Maiti [email protected]
wrote:

Ok I will then try converting this as a first-timer issue by adding more
content here.You can then label it as a first timer issue.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#7 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AABfJwijh82ttNv72Conz-_MVZzLNiTQks5qLY7zgaJpZM4BKlh9
.

from plots2.

@jywarren Hey Jeff I solved this issue in #600. I found that this problem was occurring only for wiki pages since the wiki title was not updated with each revision. But I had to update the title so as to update the wiki url. So this issue has to be closed once #600 gets merged. I think I can find other issue that can be labeled as first-timer-only issue and probably make one if found.

from plots2.

Super, that would be great. Maybe helping Liz make #599 into a first-timers only, since it's just moving html markup around, with one Ruby conditional inside?

from plots2.