Code Monkey home page Code Monkey logo

Comments (7)

MattHJensen avatar MattHJensen commented on May 29, 2024

The request that requires nu18 was for the new capability to be on TaxBrain by the 20th. It seems very unlikely that that could be accomplished if we bundle #93 with all of these other changes. Even if it could be accomplished by rushing, I don't think we should rush the adoption of the new puf.csv file.

That said, it only makes sense not to bundle #93 if we think it could be on TaxBrain by (or near) the 20th if we proceed with it first. Unless there is a shortcut I am missing, that would require:

  1. Merging #93 here.
  2. Releasing a new taxpuf
  3. Merging a forthcoming PR to tax-calculator
  4. Releasing a new taxcalc (0.9.0, probably)
  5. Creating a new conda package
  6. Testing the new taxpuf and new taxcalc against other projects
  7. Fixing outstanding compatibility issues w/ latest version of taxcalc and any new ones.
  8. Deploying to TaxBrain.

I am going to ask the requester whether the 20th was a hard deadline or a soft deadline. If it is a hard deadline, I think we should assume we can't make it. If it is a soft deadline, I think we should try to make it and potentially miss by a few days.

from taxdata.

martinholmer avatar martinholmer commented on May 29, 2024

@MattHJensen said:

That said, it only makes sense not to bundle #93 if we think it could be on TaxBrain by (or near) the 20th.

How likely is that? TaxBrain is still using 0.8.3 from May 1st, rather than 0.8.4 or the most recent 0.8.5 from June 8th.

from taxdata.

MattHJensen avatar MattHJensen commented on May 29, 2024

How likely is that?

I will get in touch with @PeterDSteinberg as well as the enhancement requester to see whether he and other webapp-public contributors have bandwidth later this week / early next week to work on deployment

TaxBrain is still using 0.8.3 from May 1st, rather than 0.8.4 or the most recent 0.8.5 from June 8th.

We can skip over taxcalc releases for TaxBrain, so the fact that we are a few releases behind shouldn't slow us down.

from taxdata.

MattHJensen avatar MattHJensen commented on May 29, 2024

I will get in touch with @PeterDSteinberg as well as the enhancement requester to see whether he and other webapp-public contributors have bandwidth later this week / early next week to work on deployment

@PeterDSteinberg thinks next Tuesday is a reasonable goal if we have the taxcalc and taxpuf releases by eod Thursday.

from taxdata.

martinholmer avatar martinholmer commented on May 29, 2024

@MattHJensen said:

TaxBrain is still using 0.8.3 from May 1st, rather than 0.8.4 or the most recent 0.8.5 from June 8th.

We can skip over taxcalc releases for TaxBrain, so the fact that we are a few releases behind shouldn't slow us down.

I interpreted TaxBrain being stuck on 0.8.3 as an indication that the code was being changed so much (for example, webapp-public pull request 556) that it was not possible to upgrade TaxBrain to 0.8.4 or 0.8.5. Otherwise, why weren't those upgrades done?

from taxdata.

MattHJensen avatar MattHJensen commented on May 29, 2024

I interpreted TaxBrain being stuck on 0.8.3 as an indication that the code was being changed so much (for example, webapp-public pull request 556) that it was not possible to upgrade TaxBrain to 0.8.4 or 0.8.5.

That's not quite right. More accurately, the pause in releases was to give the webapp-public team time to make progress on, for example, 556, rather than dealing with the releases. We did attempt a 0.8.4 release, but we thought PSLmodels/Tax-Calculator#1367 was blocking it and that it would make more sense to wait until you were back from vacation. Anyways, the short answer to why we haven't upgraded to 0.8.4 and 0.8.5 is: resource budgeting.

from taxdata.

martinholmer avatar martinholmer commented on May 29, 2024

Closing issue #95 as it has been replaced by issue #96.

from taxdata.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.