Comments (8)
Kenneth's right. The README states you should be able to reformat even well-behaved Python 2.7 code. This is simply an omission on my part because I don't run Python 2.7 on my own projects anymore.
But, the **kwargs trailing comma is such a small thing to fix that will unlock compatibility with 2.7-3.5 that I'm going to do it for sure.
from black.
I don't think this is an issue. The docs clearly state python3.6+ compatibility.
from black.
No, the tool is to be run on Python 3.6, but is to produce code compatible with even Python 2.
from black.
Watch out that this also affects
def foo(*args,): # error on 3.5 and earlier
...
def foo(a, *, b,): # error on 3.5 and earlier
...
(For reference it's bpo-9232.)
from black.
Yes, I'm familiar with the additional forms. Essentially, whenever the argument list includes a star, it's no longer safe to use a trailing comma unless such trailing comma or an f-string was already present in the file (which signifies the code is already 3.6+).
from black.
from black.
Yes, that's the flip side. An easy way to spot those for you would be to run:
$ python3.5 -m compileall .
in your directory and see where you have failures. Hopefully there's not going to be too many. Let me know, if so I'll add a temporary option to never add trailing commas so you can fix your early adopter misformattings :-)
from black.
This is now fixed as described above. @kennethreitz, let me know if you need help with unbreaking the 3.6-only formattings in your code. If those are pushed to GitHub, I will happily make a pull request that undoes the damage.
from black.
Related Issues (20)
- f-string internal formatting to be consistent with non-f-string formatting HOT 1
- INTERNAL ERROR HOT 1
- precommit black doesn't read from `pyproject.toml` file. HOT 1
- Line too long: string literal doesn't get split HOT 1
- Black fails with match-case statement with multiple branches HOT 2
- PEP 701 support breaks stability policy HOT 10
- Black cannot parse previously parseable file in 24.4.1 HOT 14
- black 24.4.1 hangs with python 3.10.12 HOT 6
- Black not deleting unnecessary brackets HOT 3
- Cannot format f-strings where the contents re-use the same quotes as the enclosing f-string HOT 1
- 24.4.2: pytest fails in tests/test_format.py with `AssertionError` HOT 3
- Cannot parse multiline f-string containing multiline string HOT 1
- Is there any way to have a permalink for a specific version in the changelog doc? HOT 5
- Unnecessary parentheses added to expression in indexed assignment
- "EOF in multi-line string" on string containing same quote nested in f-string HOT 2
- Failure to format when double-quotes are in an f-string's code block HOT 6
- Long lines that concatenate list comprehensions HOT 3
- Black Formatter not working for this code. HOT 2
- Python 3.12 `def f[T: Generics](...)` HOT 2
- Strings not being formatted by Black HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from black.