Next deployment todos about ethereum-api HOT 5 CLOSED

by v4, you mean v1.4? Sounds good, closing

from ethereum-api.

@gskapka If these are met in the next connector, please checkmark them

from ethereum-api.

Checkbox 1: Here, are we talking about the addressCustomGasPrice mapping? I'm guessing so since making the uin256 gasPrice = 20e9 public when it's essentially constant is kinda pointless right? So if it is the mapping then no, it's not currently public.

Checkbox 2: Done, now there's loads of overloads too for various usecases.

Checkbox 3: The requestCounter mapping isn't public (yet) either.

So, assuming the above para's assumptions are correct, I've made the necessary changes that'll result in ticking all three check boxes in this issue, and PRd them here.

from ethereum-api.

Update on this:

Checkbox 1: `addressCustomGasPrice is now public & has tests covering that fact.

Checkbox 2: Actually not done, since the oraclizeAPI modifier needs to be on the getPrice fxns for connector-switches, and that modifier changes the state and so fxns using it can't be view. Instead, we discussed showing in the docs how a user can achieve the same thing in their own contract should they wish to.

Checkbox 3: The requestCounter is not public and after vacilliating and making it so then reverting back again, it's been decided to keep it private so as not to foster any external dependencies on it.

from ethereum-api.

And so re this: suggest closing this issue and creating a new one to track the new next-deployment-todos, ie, those we want in v4. v1.4.

(Edited due to following comment)

from ethereum-api.