Comments (2)
@retpoline running osmx on untrusted .osmx file input seems like a nonstandard use case. Can you explain how the fuzz tester works? Considering an .osmx file is just an LMDB database, it seems like this parsing issue is relevant to any LMDB database? https://bugs.openldap.org/buglist.cgi?component=liblmdb&product=LMDB&resolution=---
from osmexpress.
@bdon thanks for looking into this.
Well, in general file parsers should not crash on malformed filed and ideally should handle error conditions that would otherwise cause them to crash gracefully instead. The fuzz testing performed was to check if the parser would handle invalid files or crash when parsing them.
As far as parsing an untrusted file as a nonstandard use case, I'd say although osmx files are different file types than doc, jpeg or other types of files, we still expect to be able to open a word document and if it contains errors, Word says eg. "Invalid file content" instead of crashing or allowing the file contents to dictate control over process memory. So that's why its a good idea to fix crashes in such scenarios.
Hmm other parses that operate on LMDB databases may crash on malformed input as well and if so, should be hardened to gracefully exit with an error message instead of allowing memory to get corrupted as well.
from osmexpress.
Related Issues (20)
- Query for multiple nodes, ways, or relations at once by ID HOT 3
- Segfault running query command with no arguments HOT 2
- augmented diff example program HOT 7
- get the approximate cell covering for a relation HOT 1
- What's the preferred linux package name for OSM Express? HOT 3
- Document how to build with system libs instead of vendored libs HOT 4
- (windows) MDB_Transaction Error when trying to work with Windows Subsystem for Linux HOT 3
- Add polygon extract queries to the Python API HOT 12
- Publish 0.0.4 osmx python bindings HOT 2
- Converting full planet pbf file fail HOT 4
- Include all metadata for locations
- S2CellUnion Expand for extract operation HOT 4
- Script to render examples/screenshot.png HOT 1
- Possible to use this to serve tiles? HOT 3
- Cannot extract node tags HOT 8
- Continuous growths of the osmx file with nightly updates HOT 5
- Master build failing on Ubuntu 22.04.1 LTS HOT 1
- Investigate string pools HOT 5
- Transactions will fail when db exceeds 1 TB
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from osmexpress.