Code Monkey home page Code Monkey logo

Comments (6)

dswarbrick avatar dswarbrick commented on May 21, 2024

I was also caught out by this, whilst trying to update Debian's packaging for prometheus-node-exporter. Version 0.18.0 seems to require a pre-0.0.1 git snapshot of procfs, whilst version 0.18.1 requires exactly version 0.0.1 of procfs. Anything later than that (0.0.2+) breaks the build due to the removal of these top-level functions:

src/github.com/prometheus/node_exporter/collector/buddyinfo.go:58:24: c.fs.NewBuddyInfo undefined (type procfs.FS has no field or method NewBuddyInfo)
src/github.com/prometheus/node_exporter/collector/cpufreq_linux.go:83:23: c.fs.NewSystemCpufreq undefined (type sysfs.FS has no field or method NewSystemCpufreq)
src/github.com/prometheus/node_exporter/collector/ipvs_linux.go:109:24: c.fs.NewIPVSStats undefined (type procfs.FS has no field or method NewIPVSStats)
src/github.com/prometheus/node_exporter/collector/ipvs_linux.go:124:27: c.fs.NewIPVSBackendStatus undefined (type procfs.FS has no field or method NewIPVSBackendStatus)
src/github.com/prometheus/node_exporter/collector/netclass_linux.go:172:23: c.fs.NewNetClass undefined (type sysfs.FS has no field or method NewNetClass)

from procfs.

cuonglm avatar cuonglm commented on May 21, 2024

cc @pgier @discordianfish

from procfs.

SuperQ avatar SuperQ commented on May 21, 2024

@dswarbrick I had to bump the procfs slightly in node_exporter 0.18.1 to fix a parsing bug.

from procfs.

dswarbrick avatar dswarbrick commented on May 21, 2024

@SuperQ Thanks for the info. Will node_exporter be releasing a new version that builds against procfs 0.0.2, or will procfs re-add some top level function wrappers like they did in #170 ?

from procfs.

SuperQ avatar SuperQ commented on May 21, 2024

We'll probably update the node_exporter master to work with the latest procfs version sometime soon. A new release depends on what features we're working.

from procfs.

cuonglm avatar cuonglm commented on May 21, 2024

@SuperQ Update node_exporter should work, but it's likely that there're user out there which rely on removed methods.

The best way to fix this is in procfs, but re-adding removed methods and mark them as deprecated. If not, the changelog should be updated to insist the in-compatible change.

from procfs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.