packaging fails when cdk.out dir is significant in size about projen HOT 9 CLOSED

Nice catch!

I don't like that rsync step anyway. Yet another reason to refactor it. Although if packaging runs, you're not running rsync. 🤔

One question though: How come you have a cdk.out directory in a construct library?

from projen.

I think this is a simple as adding cdk.out to .gitignore and .npmignore for the awscdk-construct project.

from projen.

Just need to add a line like this

Let me know and I can prep a PR to do that.

from projen.

I've looked into this more. Long story short, anyone running integ tests should either

• use the built-in integration test feature, or
• use the experimental integ-runner feature, or
• use the CdkConfig component to configure the config for the integ test.

All three of these options already prevent this issue from happening. In particular CdkConfig adds the configured cdk out dir to .gitignore.

For anyone choosing a custom implementation (which is reasonable choice) it will be on them to ensure the implementation is complete. Given that we already have 3 viable options for this, I'm not keen to speculatively support custom implementations.

from projen.

The cdk.out dir must be coming from testing. To test the construct I'm building, I run this command in the root dir:

npx cdk deploy --app lib/my-construct/integ.default.js

where the integ.default.js file contains the CDK code that references the construct I'm building.

Here's an example of such a file: integ.default.ts

from projen.

Adding cdk.out to .npmignore (via .projenrc.ts) worked for me!

Thanks!

from projen.

Would love a PR for this 😉

from projen.

Yes that should be it. Run the build locally to update the snapshots and you are good to go!

from projen.

Thanks for the update. Apologies for dropping the ball on this one.

from projen.