Comments (6)
I'm not sure I remember the exact situation. If you can help me recall what issues this is attempting to resolve and how, I can be of more assistance to you.
from projen.
Basically, workflow jobs get pretty readonly at the moment, fairly closed to modification. You recommended they should become a class to alleviate this at the same time as you recommended that TaskWorkflowJob become a class (which that class now extends the new one).
As an outside user making constructs, adding an env variable to a job looks like this:
const job: Job;
const updatedJob = {
...job,
env: {
...job.env,
newEnv: newValue
}}
workflow.updateJob("jobName", updatedJob);
I propose:
const job: Job;
job.addEnv("newEnv", newValue);
The perfect naming and way to achieve this escapes me, but I think the idea is quite sound and well paved in other parts of projen.
from projen.
Ping @mrgrain for feedback because I must always be bothering you with at least 1 thing.
from projen.
Thanks @dkershner6 I'm happy to move ahead with this. It will be relatively low priority on my end, so I'd also recommend you to look for experienced peers to provide reviews to make the cycles quicker.
And please make sure you write some docs around this as part of the PR.
from projen.
Thanks @dkershner6 I'm happy to move ahead with this. It will be relatively low priority on my end, so I'd also recommend you to look for experienced peers to provide reviews to make the cycles quicker.
And please make sure you write some docs around this as part of the PR.
Appreciate the feedback, Momo. I will think about this some more versus adding more preSteps
and postSteps
. Really, I just don't like violating readonly access, but that is our current course of action, which works as well.
from projen.
Maybe worth something someday, but just going to close for now.
from projen.
Related Issues (20)
- Export util modules HOT 9
- Unable to ignore lines for coverage in projen project HOT 1
- `npx projen new jsii --package-manager npm` fails due to peer dependency issue HOT 2
- Publish to CodeArtifact fails for Nuget packages HOT 2
- github issue template
- Publishing v0.81.11 to PyPI failed HOT 1
- Generated source code for LambdaFunction where `edgeLambda: true` is incorrect HOT 3
- Release tags wrong commit HOT 1
- !reference tag in gitlab job scripts will be rendered in quotes
- typeRoots is missing in TypescriptConfigOptions
- moduleDetection is missing in TypescriptConfigOptions
- Getting Started on home page is broken HOT 1
- setfacl is not pre-installed on CodeBuild images HOT 2
- No validation done on name except duplicate checking
- Add `projenrc` dir to Jest test match list
- feat(tsconfig): removeInclude/Exclude
- bug(typescript): By default, TypeScriptProject (and derivatives) compile and publish test files in `src`
- Setting projenVersion attempts to pull projen from private npm registry HOT 3
- Mismatching version for `@aws-solutions-constructs` HOT 4
- Licenses applied wrong HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from projen.