Feature request: allow multiple source directories about projen HOT 12 CLOSED

Sounds good. Should be fairly easy to support. Contributions are welcome

from projen.

Does it make sense to pass srcDirs for each component in the rc or should the construct pass srcDirs to all components for you ?

from projen.

I think passing srcDirs to all relevant subcomponents for you would be a sensible default - but it should still be possible to override the choices on an per-component basis (e.g. if you don't want to lint a folder that has legacy code, but you still want to compile/build it). Overriding per-component srcdirs should probably through directly assigning to certain fields or calling an API.

Perhaps we could change the srcdir option/param to be an array of strings instead (or add a srcdirs flag and deprecate srcdir)? This might require changes in several places - but the endgoal though is to represent a simpler / more flexible mental model. If a specific project type like a CDK app requires there to be only one source directory, then a runtime check could be added to the constructor to validate that the srcDirs list is length 1.

from projen.

This issue is now marked as stale because it hasn't seen activity for a while. Add a comment or it will be closed soon.

from projen.

Don't close

from projen.

Closing this issue as it hasn't seen activity for a while. Please add a comment @mentioning a maintainer to reopen.

from projen.

Reopening. This is a currently an issue since cdk8s projects (created with projen new cdk8s-app-ts) cannot use any cdk8s imports they generate, since the src and imports directories are separate and the generated tsconfig.json has rootDir set to src.

A temporary workaround for the above issue is to use an escape hatch:

project.tryFindObjectFile('tsconfig.json').addDeletionOverride('compilerOptions.rootDir');

from projen.

For JSII projects (like construct libraries), the above workaround doesn't work since tsconfig.json is managed/generated by jsii. But today I realized that JSII actually does support multiple source directories, it just requires that "rootDir" option in JSII's typescript options has to be left empty! source:

https://github.com/aws/jsii/blob/2120d34ef74597a6c7995e7798947a6fc931df04/packages/jsii/lib/compiler.ts#L314

So a workaround for JSII projects is:

project.tryFindObjectFile('package.json').addDeletionOverride('jsii.tsc.rootDir');

Edit: Actually I guess this only does a little bit since you still need a single root of your project with an index.ts file, otherwise JSII starts to complain.

(Somewhat relatedly, JsiiProject has a rootdir option which doesn't do anything...)

from projen.

This issue is now marked as stale because it hasn't seen activity for a while. Add a comment or it will be closed soon.

from projen.

Closing this issue as it hasn't seen activity for a while. Please add a comment @mentioning a maintainer to reopen.

from projen.

This issue is now marked as stale because it hasn't seen activity for a while. Add a comment or it will be closed soon. If you wish to exclude this issue from being marked as stale, add the "backlog" label.

from projen.

Closing this issue as it hasn't seen activity for a while. Please add a comment @mentioning a maintainer to reopen. If you wish to exclude this issue from being marked as stale, add the "backlog" label.

from projen.