Comments (15)
Figured it out, it was extremely stupid. update incoming
from panorama-tab-groups.
It's fixed, basically when some options were added to the options page in the shape of a <form>, there wasn't a corresponding </form> which meant that the save backup button was counted as the button for the form. And because it's not a proper form, the button didn't do anything. Closed the form properly and the button works now. Easy mistake to make and easy to fix, just hard to find :)
git bisect was particularly helpful
from panorama-tab-groups.
Ah yes, the little gear I didn't know was there :) All is well and my anxiety level has declined. My sincere gratitude for the fix!
from panorama-tab-groups.
I'll check on this, I don't really use the backup feature myself (and someone else has worked on this in the past), I'm sorry I didn't miss this feature breaking. I'll go check on it when I can and see why it doesn't work.
from panorama-tab-groups.
The code stops at this line:
https://github.com/projectdelphai/panorama-tab-groups/blob/master/src/js/backup.js#L106
The console says TypeError: Argument 1 of StructuredCloneHolder.deserialize is not an object.
🤔
Sadly, it seems the debugger doesn't work properly, I can't even step into the code and look for the part which stops.
This states that it's coming from here:
https://searchfox.org/mozilla-central/source/toolkit/components/extensions/ExtensionChild.jsm#1016
The odd thing is, this logs correct:
browser.sessions.getWindowValue(windows[wi].id, 'groups').then((data) => {
console.log('groups', data);
});
browser.sessions.getWindowValue(windows[wi].id, 'groupIndex').then((data) => {
console.log('groupIndex', data);
});
browser.sessions.getWindowValue(windows[wi].id, 'activeGroup').then((data) => {
console.log('activeGroup', data);
});
and this not:
const groups = await browser.sessions.getWindowValue(windows[wi].id, 'groups');
const groupIndex = await browser.sessions.getWindowValue(windows[wi].id, 'groupIndex');
const activeGroup = await browser.sessions.getWindowValue(windows[wi].id, 'activeGroup');
console.log('groups', groups);
console.log('groupIndex', groupIndex);
console.log('activeGroup', activeGroup);
from panorama-tab-groups.
Just wanted to say that this feature is also extremely important to me as well. If Firefox's "Restore previous session" gets unchecked, as happened to me with the v.65 update, you get the "Do you want to close all tabs" when you exit and can't exit without doing it. This causes all tab groups to be lost. Keeping a backup lets you import those tab groups back in. It's a lifesaver.
from panorama-tab-groups.
In case of @HGondorff an automatic backup would be nice. But this would be a different feature.
from panorama-tab-groups.
Just want the Save Backup button to work again, please. Hope someone figures it out.
from panorama-tab-groups.
I've lost all my tab groups multiple times with various Tab Groups extensions over the years (including this one). I don't have the logs/details to reproduce it, but I'd simply open up Firefox one day and find all tab groups as one huge group.
Posting this to +1 a backup/save feature fix
from panorama-tab-groups.
@projectdelphai Something got eaten in your comment. ;) Did you use an HTML tag? Markdown understands HTML so if you post code you need to wrap it in backticks or we won't see it.
from panorama-tab-groups.
The update is not coming through. I'm still stuck with 0.8.7. I am tempted to delete and download the new version but am afraid of losing my tabs in the process. I have tried setting the updates to default and automatic to no avail.
from panorama-tab-groups.
@HGondorff this link should help you out if you really can't update. That being said, have you tried clicking the little gear on the right hand side of the PTG options page? It'll allow you to automatically download the new update. Firefox only checks once a day, so that might be why your update hasn't come in yet.
If you have tried to manually update, then there might be something else wrong.
from panorama-tab-groups.
@mgol lol yeah i escaped the html tags so it should be good now, thanks for letting me know. Didn't realize backticks helped escape too, I just used back slashes by default and that worked too.
from panorama-tab-groups.
anytime :)
from panorama-tab-groups.
Opening the extension's preferences and clicking "Save backup" does nothing. Therefore, performing a backup is impossible.
Same issue here. Noticed it only after restarting Firefox.
Also, I noted the "keyboard shortcuts" fields are empty (like the shortcuts for PTB have been removed). Maybe they could not be read from somewhere (the place where this info was stored)?
I'm not an expert, but it seems incompatibility with some other add-on. PTG was working flawlessly before the restart.
My system:
Firefox 88.0.1 (64-bit) on Linux Mint 19.2 Cinnamon
PTG v. 0.8.12
All add-ons / addons / extensions I have here:
- Adblock Plus - free ad blocker
- All Downloader Professional
- Autofill
- Awesome Emoji Picker
- Best Proxy Switcher
- Change Case
- Chrome Remote Desktop
- Conex
- Copy Link Text
- Download Star
- DownThemAll!
- DuckDuckGo
- Emoji Cheatsheet for GitHub, Basecamp etc.
- Fess Google Bookmark Extension
- Firefox Multi-Account Containers
- Greasemonkey
- Image Search Options
- Panorama Tab Groups
- Rotate and Zoom Image
- Saka Key
- Search by Image
- Startpage
- Stylish - Custom themes for any website
- Video Downloader professional
- Video DownloadHelper
- View Image
- Wikipedia (en)
- Yahoo!
- YouTube Tooltip & Notification
- English (CA) Language Pack
- English (GB) Language Pack
from panorama-tab-groups.
Related Issues (20)
- "Close tabs on the right" kills all tabs, in all groups...
- tab group numbering
- Tabs mysteriously disappear when alt-tabbing to another browser
- View changes every now and then automatically from "Freeform (classic)" back to "Popup".
- [Request] Zoom in/out transition
- [Request] Ability to set custom CSS
- ctrl+tab doesn't work across tab groups
- [Request] Fork Panorama to Chrome? HOT 3
- [REQUEST] Allow color customization
- Popup view fails when tab title contains HTML
- Pulling a tab out of the window in Firefox causes the window it was originally in to act like it has only one tab until more tabs are added HOT 4
- [Feature request]Can we makes "Automatic alignment" always available without click it?
- hiding tabs
- When pulling a tab into a new window and then opening a new tab, the first tab in the new window becomes hidden.
- Groups on sidebar
- Saved groups and tabs are gone HOT 1
- default tab group
- Feature request, sync or perform scheduled backup periodically HOT 1
- Importing old Panorama View JSON does not work, despite import setting saying it does
- [Request] Ability to change the tabs thumbnails to custom or at least select from predefined icon group
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from panorama-tab-groups.