Code Monkey home page Code Monkey logo

Comments (20)

LuccoJ avatar LuccoJ commented on June 19, 2024 2

I've opened an issue concerning the app at https://gitlab.com/fdroid/fdroiddata/issues/1429 because I feel it's not presented in an ideal way in its F-Droid description. I would appreciate if the app's developers could weigh in on the stated concerns, as they would necessarily be the best-informed parties about the services the application makes use of and their status wrt tracking and freedom.

Please keep in mind that while my issue may sound like criticism of the application, the goal is just to have applications consistently described in F-Droid and let users know what to expect.

from travel-mate.

Rudloff avatar Rudloff commented on June 19, 2024 1

It looks good to me, I will try to work on it next week.

from travel-mate.

Swati4star avatar Swati4star commented on June 19, 2024

@Rudloff Sure! You can add a merge request for this project on FdroidData.

from travel-mate.

Rudloff avatar Rudloff commented on June 19, 2024

Great!

Would it be possible to tag releases?
This makes packaging a lot easier.

from travel-mate.

Swati4star avatar Swati4star commented on June 19, 2024

Hi @Rudloff ! Sure. Just specify the tag format you want me to create. Also, make the app auto update on Fdroid.

from travel-mate.

Rudloff avatar Rudloff commented on June 19, 2024

If we want to enable auto update, the easiest way is to have tags that match the version name of the app (e.g. 2.0 for the current version).

from travel-mate.

Swati4star avatar Swati4star commented on June 19, 2024

https://github.com/project-travel-mate/Travel-Mate/releases/tag/2.0

Let me know if you want me to do any other change.

from travel-mate.

Rudloff avatar Rudloff commented on June 19, 2024

Sorry, I just noticed you are using some Play Services libraries:

implementation 'com.google.android.gms:play-services-maps:15.0.1'

Unfortunately, these are not open-source so we can't include it in F-Droid (unless we could build a variant of your app wihtout these libraries but that's probably a lot of work).

from travel-mate.

Swati4star avatar Swati4star commented on June 19, 2024

We need maps in our application. After all, this is a travel app!

from travel-mate.

Rudloff avatar Rudloff commented on June 19, 2024

If you are interested, there are some open-source alternatives to Google Maps like osmdroid.

I'm sorry, I didn't notice this dependency when I first had a look at your code. But I'm afraid this means we can't publish it on F-Droid.

from travel-mate.

Swati4star avatar Swati4star commented on June 19, 2024

Hi @Rudloff ! We have removed the usage of google maps, and replaced it with osmdroid.
Can you check if it can be published on f-droid now?

from travel-mate.

Rudloff avatar Rudloff commented on June 19, 2024

That is great!
It should be OK now. I will start working on packaging the app.

from travel-mate.

Rudloff avatar Rudloff commented on June 19, 2024

@Swati4star I created a build recipe for the app: https://gitlab.com/fdroid/fdroiddata/merge_requests/3803
I just had to remove the http://repo.commonsware.com.s3.amazonaws.com repository (not sure how it is used).

Do you think it would be possible to add Git tags for 3.9.2 and future releases? It makes packaging updates a lot easier.

from travel-mate.

Swati4star avatar Swati4star commented on June 19, 2024

Hi @Rudloff
Sure, I'll add git tag for current & future releases as well.
https://github.com/project-travel-mate/Travel-Mate/releases/tag/3.9.2

from travel-mate.

Swati4star avatar Swati4star commented on June 19, 2024

I think, adding https to the url will solve the issue.

from travel-mate.

Swati4star avatar Swati4star commented on June 19, 2024

The gitlab build should pass after this commit, 25ed727

I have created a new release with the above commit included also.

from travel-mate.

Rudloff avatar Rudloff commented on June 19, 2024

Everything works correctly now, thanks!

from travel-mate.

Swati4star avatar Swati4star commented on June 19, 2024

Do share the fdroid link, when it is merged on gitlab.

from travel-mate.

guest4711 avatar guest4711 commented on June 19, 2024

It's on f-droid now: Travel Mate (A complete travel guide) - https://f-droid.org/app/io.github.project_travel_mate

from travel-mate.

Swati4star avatar Swati4star commented on June 19, 2024

I'll update the readme soon to incorporate your comments 💯

from travel-mate.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.