every activity/fragment should have getStartIntent() / getNewInstance() about travel-mate HOT 26 CLOSED

May I work on this?

from travel-mate.

@stupidly-logical
Sure, go ahead with it. Make sure the changes are in accordance with the checkstyle rules.

from travel-mate.

That was just an example.
For city related fragment/activities, pass City object
Whatever seems to be relevant to be passed to the corresponding activity/fragment, add that parameter. If nothing seems to be relevant, don't add any parameter.
@brijeshshah13

from travel-mate.

@brijeshshah13
The benefit of creating it for activities:

• Cleaner code
• Less code repetition. (In case n activities are calling X activity)
• Promotes abstraction: handle complexity by hiding unnecessary details from other classes(Activities).

And about 2 copies, we won't be having 2 copies. At any point in time, there will be only 1 copy in the memory.

from travel-mate.

@Swati4star Thank you for listing down the advantages. On it.

from travel-mate.

Yes, Use activity_name.getStartIntent() this syntax. Will be more readable.

from travel-mate.

No. Leave that Activity.

from travel-mate.

@stupidly-logical sure , go ahead with , make sure u create new branch

from travel-mate.

One issue I encountered while solving this issue is that Activities and Fragments file names are not ending with "Activity"/"Fragment" respectively.
Your views on this : @Swati4star @gugakatsi ?

from travel-mate.

@stupidly-logical yeah , they should be , u mean SomeActivity.java right...

from travel-mate.

@gugakatsi yes exactly, I'll fix this too. @Swati4star ?

from travel-mate.

@stupidly-logical i like that idea.

from travel-mate.

@stupidly-logical Any updates on this issue? Are you working on this?

from travel-mate.

@Swati4star Yes, I'll send PR soon

from travel-mate.

this issue is being solved in #50
thanks @stupidly-logical

from travel-mate.

@Swati4star Can I start working on this?

from travel-mate.

Sure @brijeshshah13 👍

from travel-mate.

@Swati4star What is User as stated in the example in the beginning?

from travel-mate.

Specify the line of code you are referring to

from travel-mate.

Parameter passed in public static Intent getStartIntent(Context context, User user) and public static UserFragment newInstance(User user)

from travel-mate.

@Swati4star Thinking it in detail, do we really require getStartIntent() for Activities because when we will be wanting an Intent for a certain activity, we are passing the Context and reference of the Activity anyway. Plus, if we implement this for Acitivities, we will be creating 2 copies of Intent even though one is enough. To the best of my knowledge, I think we should implement this functionality only for Fragments. Please share your views.

from travel-mate.

@Swati4star By using the same method name getStartIntent() for all activities will result into confusion as it will be directly called, so shall I add the name of the activity in the method?

from travel-mate.

the method will be static, so it will be called using the ClassName of particular activity/fragment. I don't think it will create confusion. Rather, it would make it easier.

from travel-mate.

That will be for Fragments, when I use activity_name.getStartIntent(), Android Studio tells me to directly refer the method without using the reference of activity getStartIntent() as it will directly import that method. Still, I can use the former syntax though. Shall I go with it?

from travel-mate.

What about the ImagePickerActivity? Wanted to assure if I should add the method to that activity as it is decompiled .class file with a different package name all together.

from travel-mate.

Fixed by #144

from travel-mate.