CI/CD Pipeline setup about monai HOT 3 CLOSED

Yan, I'm taking the liberty of copying your initial email here as it is the best place for discussion

Hi Ben,

This item was assigned to you and me. If you don’t mind, I can do some research on possible solutions and put together a proposal.

But we need to first define some requirements. Here are what I can think of:

When PR merge request is received:
Check and make sure the PR has been reviewed and approved.
Run code style check and email result to author
Run all unit tests and make sure nothing is broken
Run integration tests and make sure nothing is broken
Notify team if the PR is accepted
Nightly build?

Please feel free to add/change.

Depending on the solution options we have, we may need to adjust these.
Let me know what you think.
Thanks,
Yan

from monai.

We have been using 'GitLab CI/CD for GitHub' as it comes with full GPU test agent support. Shall we just go with that?

Let's protect master so that it can only be updated via PR.

Github provides 'auto-squash' option on PRs so that they are always a single commit on master. This is good because it keeps master history clean. I'd go further and suggest rewriting commit message for the PR so that it summarises the feature.

Re checks, we should be able to configure CI so that testing happens automatically on PR submission (i.e. before it has been passed/merged). All unit and integration tests should be run on a CI basis, ideally.

We can have a nightly build. We may wish to have longer running training tests that execute on it. It is a bit tricky given the unstable nature of some networks, however.

Notification of the team; I guess you mean automatic emails; don't we get them from the issues, updates to the issues? If not, I guess that there is a hook of some kind.

from monai.

Thanks @atbenmurray, just to confirm that now the master can only be updated via PR, squash merging is enabled for PR.

from monai.