Comments (6)
We should consider triggering resubscribe on both CASE establishment (using the new session, not creating a new one), and on any IM message received, not just ReportData.
from connectedhomeip.
Assigning to me.
from connectedhomeip.
In particular, we only retrigger subscription on receiving a ReportData, not on CASE establishment from the other side or the other side sending any other IM message.
from connectedhomeip.
I'm taking a look but my first thought is that currently the logic for re-subscription is only triggered when the IME gets called on OnUnsolicitedReportData. I could look into the changes needed to have CASE establishment plumb through to trigger re-subscribe and we can discuss if that's what's needed here.
@ndyck14 Do you happen to be able to readily reproduce this? If so could you upload logs from both devices?
I'm wondering if there's something else wrong / a bug that's causing this, that should be fixed first.
from connectedhomeip.
Power cycle HPM (unclear if strict precondition)
I did this with the intent of clearing CASE resume contexts (guesswork) so as to test worst case. Basically my brief mental model of resume sub is its a best effort by device. Otherwise CASE is re-established because we're looking for OTA i think.
I can try to reproduce, but is there evidence to suggest that this onus should not be on the subscriber to ensure its done as swiftly as possible? I guess in case the sub is already active, we don't want to double up? Is doubling up even possible?
from connectedhomeip.
note that my test steps were in done directed after already observing this previously without logs installed, so I've seen this happen multiple times. I've also been tracking CASEs (pun intended) for a year or more where things take too long to reconnect (eg #25091, which Boris reported on my behalf )
from connectedhomeip.
Related Issues (20)
- Dependabot fails with `there was not enough disk space available`
- [TC-RR-1.1] INFO Step 14: Setting group key map on fabric 6 Error . HOT 5
- Few follow ups on top of #32516
- [BUG] RVC app missing in SDK Docker image
- Basic Info cluster: add DeviceLocation attribute
- Do not set up subscription for remote controllers when delegate is set
- [Documentation] Linux dishwasher-app example README wrongly refers to lighting app
- [Documentation] Linux refrigerator-app example README wrongly refers to lighting app
- Add HomeLoc struct to chip-types.xml
- Add a location attribute to the Basic Information cluster
- [BUG] [Python] Read returns ReadResponse when subscription setup did not complete
- Address followup comments from https://github.com/project-chip/connectedhomeip/pull/33559
- [Feature] Add a metric when a ReadClient resubscribe is triggered.
- [Test Failed] TestAccessControlCluster.yaml is expecting wrong error on "too many subjects/targets" HOT 2
- [Documentation] Matter Linux Microwave Oven Example refers to Lighting app
- operate a light 32-bit.
- RVC Mode clusters: Remove Idle constraints. HOT 2
- Write the test plan for Direct Mode Change feature HOT 1
- [Feature] Add Fabric RPC service to Fabric Admin
- [Feature] Add Fabric Bridge RPC service to Fabric Bridge
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from connectedhomeip.