Code Monkey home page Code Monkey logo

Comments (9)

woody-apple avatar woody-apple commented on May 27, 2024 1
    ChipLogError(Controller, "Creating NSError from %" CHIP_ERROR_FORMAT, errorCode.Format());

Log which MTRDevice (and nodeID) this is for

from connectedhomeip.

woody-apple avatar woody-apple commented on May 27, 2024 1
    ChipLogError(SecureChannel, "CASESession timed out while waiting for a response from the peer. Current state was %u",
                 to_underlying(mState));

We should log the nodeID here.

from connectedhomeip.

woody-apple avatar woody-apple commented on May 27, 2024 1
    if (err == CHIP_NO_ERROR)
    {
        ChipLogProgress(Controller, "Successfully finished commissioning step '%s'", StageToString(report.stageCompleted));
    }
    else
    {
        ChipLogProgress(Controller, "Error on commissioning step '%s': '%s'", StageToString(report.stageCompleted), err.AsString());
    }

    if (err != CHIP_NO_ERROR)
    {
        completionStatus.failedStage = MakeOptional(report.stageCompleted);
        ChipLogError(Controller, "Failed to perform commissioning step %d", static_cast<int>(report.stageCompleted));
        if (report.Is<AttestationErrorInfo>())
        {

This area in AutoCommissioner (and more down there) to allow us to know which device we're talking to (Could be vid/pid, etc)

from connectedhomeip.

carol-apple avatar carol-apple commented on May 27, 2024 1

Logging NodeID would be great here too:

MTR_LOG_DEFAULT("Read attribute work item [%llu] report duplicate %@", workItemID, readItem);

Along with all other logging in MTRDevice.mm that begins with "Read attribute work item"

from connectedhomeip.

woody-apple avatar woody-apple commented on May 27, 2024
        ChipLogProgress(ExchangeManager,
                        "Retransmitting MessageCounter:" ChipLogFormatMessageCounter " on exchange " ChipLogFormatExchange
                        " Send Cnt %d",
                        messageCounter, ChipLogValueExchange(&entry->ec.Get()), entry->sendCount);

Let's add the nodeID and/or more context so we can figure out what this is retransmitting to

from connectedhomeip.

woody-apple avatar woody-apple commented on May 27, 2024
    ChipLogError(Discovery, "Mdns: Resolve failure (%s)", errorStr);

We should log what we're trying to discover here.

from connectedhomeip.

woody-apple avatar woody-apple commented on May 27, 2024
            ChipLogError(ExchangeManager,
                         "Failed to Send CHIP MessageCounter:" ChipLogFormatMessageCounter " on exchange " ChipLogFormatExchange
                         " sendCount: %u max retries: %d",
                         messageCounter, ChipLogValueExchange(&ec.Get()), sendCount, CHIP_CONFIG_RMP_DEFAULT_MAX_RETRANS);

Add nodeID to this

from connectedhomeip.

bzbarsky-apple avatar bzbarsky-apple commented on May 27, 2024

Let's add the nodeID and/or more context so we can figure out what this is retransmitting to

We could, but the message counter can be used to find the original transmission, which has that info...

Log which MTRDevice (and nodeID) this is for

That information is not currently available there. We could add another initializer which allows passing it in, and update all the callsites that have that info, of course.

from connectedhomeip.

woody-apple avatar woody-apple commented on May 27, 2024

The key here is to have it on a single line, without manual humans reading through logs trying to associate things

from connectedhomeip.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.