Code Monkey home page Code Monkey logo

Comments (3)

jamesharrow avatar jamesharrow commented on May 27, 2024

I think this Issue may be raised incorrectly since in order to support PA,STA, PAU features you need to support SFR or PFR as well.
If you support PFR you may optionally also support SFR, and vice versa (if you support SFR you may optionally also support PFR).

So at the very least the expected value should allow 0x1F (both SFR & PFR), 0x1b (PFR is on), or 0x17 (SFR is on).

The other question is just because a feature is marked as provisional in the AppClusters spec, should we be stopping these features being enabled and failing them? @cecille raised this question yesterday.
The current test plan says that they shall not be set. But maybe the test plan needs changing here?

from connectedhomeip.

jamesharrow avatar jamesharrow commented on May 27, 2024

NOTE:
The test spec PR https://github.com/CHIP-Specifications/chip-test-plans/pull/3866 should have been used for the testing.

from connectedhomeip.

jamesharrow avatar jamesharrow commented on May 27, 2024

Based on discussion with Cecille, and clarification that '31' is a decimal value = 0x1F.
I will update the EnergyManagementApp to remove bits 5 & 6

from connectedhomeip.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.