Comments (3)
The Python used is process.kill()
. We could process.terminate()
but there is no guarantee that this will actually kill the process, and some of the bits here absolutely need to make sure the process dies (e.g. so it releases the port).
If you have specific suggestions on how to improve this while preserving the existing invariants, a PR is probably best....
from connectedhomeip.
I'm unfortunately not a python developer. I created the issue on request of @cecille. But yes I it would be the only way I could try to add this as a PR. I might do that if noone with more python experience jumps on it :-)
I just read that process.kill("SIGINT")
could be used to send a SIGINT, but yes that would require maybe to check delayed afterwards if the process was really stopped and maybe send a kill 1-2s afterwards again or such ...
A proper teardown including sending MDNS expires and such is also very important because else the test see wrong MDNS devices and react strange or error.
from connectedhomeip.
@bzbarsky-apple @cecille Ok, I tried my best and came up with that after digging a bit into python ... Pleas ebe nice to my ... my first python changes ;-))
I tested it locally and it works from my perspective
from connectedhomeip.
Related Issues (20)
- Dependabot fails with `there was not enough disk space available`
- [TC-RR-1.1] INFO Step 14: Setting group key map on fabric 6 Error . HOT 5
- Few follow ups on top of #32516
- [BUG] RVC app missing in SDK Docker image
- Basic Info cluster: add DeviceLocation attribute
- Do not set up subscription for remote controllers when delegate is set
- [Documentation] Linux dishwasher-app example README wrongly refers to lighting app
- [Documentation] Linux refrigerator-app example README wrongly refers to lighting app
- Add HomeLoc struct to chip-types.xml
- Add a location attribute to the Basic Information cluster
- [BUG] [Python] Read returns ReadResponse when subscription setup did not complete
- Address followup comments from https://github.com/project-chip/connectedhomeip/pull/33559
- [Feature] Add a metric when a ReadClient resubscribe is triggered.
- [Test Failed] TestAccessControlCluster.yaml is expecting wrong error on "too many subjects/targets" HOT 1
- [Documentation] Matter Linux Microwave Oven Example refers to Lighting app
- operate a light 32-bit.
- RVC Mode clusters: Remove Idle constraints.
- Write the test plan for Direct Mode Change feature HOT 1
- [Feature] Add Fabric RPC service to Fabric Admin
- [Feature] Add Fabric Bridge RPC service to Fabric Bridge
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from connectedhomeip.