Code Monkey home page Code Monkey logo

Comments (3)

bzbarsky-apple avatar bzbarsky-apple commented on May 27, 2024

The Python used is process.kill(). We could process.terminate() but there is no guarantee that this will actually kill the process, and some of the bits here absolutely need to make sure the process dies (e.g. so it releases the port).

If you have specific suggestions on how to improve this while preserving the existing invariants, a PR is probably best....

from connectedhomeip.

Apollon77 avatar Apollon77 commented on May 27, 2024

I'm unfortunately not a python developer. I created the issue on request of @cecille. But yes I it would be the only way I could try to add this as a PR. I might do that if noone with more python experience jumps on it :-)

I just read that process.kill("SIGINT") could be used to send a SIGINT, but yes that would require maybe to check delayed afterwards if the process was really stopped and maybe send a kill 1-2s afterwards again or such ...

A proper teardown including sending MDNS expires and such is also very important because else the test see wrong MDNS devices and react strange or error.

from connectedhomeip.

Apollon77 avatar Apollon77 commented on May 27, 2024

@bzbarsky-apple @cecille Ok, I tried my best and came up with that after digging a bit into python ... Pleas ebe nice to my ... my first python changes ;-))

#31650

I tested it locally and it works from my perspective

from connectedhomeip.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.