probot-translate-comments about ideas HOT 11 OPEN

Hi! My teammate @Akshitaag and I would love to take this issue up as a part of our RGSoC proposal!
Additionally @bogas04 is our coach for RGSoC so we'll have a great time making this bot! :)

from ideas.

Amazing!

Plan:

• onInstall: raise a PR adding a config file with set defaults.
  • Figure out default language (destination language) for the repo from commit history. Multiple languages can be added in case maintainers are bilingual.
• onMerge: Once merged, comment on same PR in some foreign language just to test.
• Use <details> to have cleaner comments instead of spamming the thread with paragraphs of poor translation.

This bot would do a lot of work;

• Detect language from a string
• Read commit history
• Raise PR
• Detect when a particular PR is merged, comment on it
• Comment whenever a comment with foreign language is found with translated text/link.
• We'll have to make sure it doesn't translate itself to avoid infinite loops, yet it must allow one test comment from itself.

from ideas.

Typically, config files for GitHub/Probot Apps are stored in the repo's .github folder, so the codebase isn't touched much and it'd be handled in one commit.

Personally, I'd rather have my project's config as part of the codebase than somewhere in an issue that is liable to get lost, but its up to you 🤷‍♂️

For what its worth, #0CJS is awesome, but that doesn't mean it shouldn't be configurable at all; smart defaults, like having the default translation destination be English, would be good enough for most projects (I'm guessing)

from ideas.

Oh, I wasn't aware that we already use config files in certain cases, in that case let's go with a config file. Yeah, the issue thing is kinda hacky anyway.

Regarding defaults, while English is good enough, we can probably do slight search to figure that out as well. The major pain point would be to detect what language given string is in. Once we settle for its logic/npm module, we can use same on, umm, commit history, to find top language and use it as target/destination language. Sounds good?

from ideas.

Once we settle for its logic/npm module, we can use same on, umm, commit history, to find top language and use it as target/destination language. Sounds good?

That'd be really, really cool! Since it'd be per repo, and you wouldn't want to do that search on every comment, you'd probably want to have the app make a PR adding the config file when its installed. This also has the benefit of introducing the maintainers to the app, and to have them check to make sure that the proposed language is correct, as a second human check.

from ideas.

Yes, we would love to work on this issue. @gr2m what are your thoughts?

from ideas.

Sure, fee free to add it to your submission :)

from ideas.

Hi @vidu171 !
There hasn't been any progress on this issue yet. Please go ahead with the implementation. Feel free to reach out for any help. Cheers!

from ideas.

This is an awesome idea! I'd love to see auto-detect so that it just works passively. Maybe a config file to denote the destination language for that repo, so that it isn't always translating to English by default? And even using <details> to say "Translated from ____"

from ideas.

Hi @JasonEtco,

Thanks for taking time to read this through. I didn't like the idea of config file as it's kinda intrusive to the codebase, I mean JS world is going #0CJS lol. I guess you misunderstood the closed issue thingy. So the maintainer can create an issue with some format, which probot app can fetch and parse to get required stuff. This way it doesn't affect the code base/commit lot and can be tweaked by updating that closed issue.
But anyway, we can store those details somewhere (issues/file).

<details> is really nice to avoid noise.

from ideas.

@Rahmeen14 @Akshitaag was any submission made on this?. If it's a work in Progress I'd love to contribute.

from ideas.