Comments (4)
Released as 6.5.1, thanks for your contribution!
from markdown-to-jsx.
After further investigations, it seems a more global problem:
These markdown input render differently:
<div class="green">
Hello
</div>
<div class ="green">
Hello
</div>
<div class= "green">
Hello
</div>
<div class = "green">
Hello
</div>
if this is parsed using regex, would it be possible to add something like:
/ *= */
if yes, I'd be glad to help
from markdown-to-jsx.
Got into the code and found these bits:
const ATTR_EXTRACTOR_R = /([-A-Z0-9_:]+)(?:\s*=\s*(?:(?:"((?:\\.|[^"])*)")|(?:'((?:\\.|[^'])*)')|(?:\{((?:\\.|{[^}]*?}|[^}])*)\})))?/gi;
and
function attrStringToMap (str) {
const attributes = str.match(ATTR_EXTRACTOR_R);
return attributes ? attributes.reduce(function (map, raw, index) {
const delimiterIdx = raw.indexOf('=');
if (delimiterIdx !== -1) {
const key = normalizeAttributeKey(raw.slice(0, delimiterIdx));
const value = unquote(raw.slice(delimiterIdx + 1));
...
Should be where the planets align together.
Now, I could suggest another approach to prevent parsing attributes twice. In fact, the regex oddly catches relevant groups into one single part, then it is parsed again using indexOf('=')
, right ?
Couldn't we leverage regex groups to naturally handle attributes key/value split for us ? something like:
/([-A-Z0-9_:]+)\s*=\s*(?:"([^"]+)"|'([^']+)'|\{([^{]+)\})/gi
where 4 groups can be extracted: attribute key, double quoted value, single quoted value and curly brackets enclosed value. Then unquote
would not even be needed.
What do you think ?
from markdown-to-jsx.
Submitted PR in a very lightweight fashion (by just trimming down spaces before parsing) + corresponding tests :)
from markdown-to-jsx.
Related Issues (20)
- follow up on #520 HOT 1
- 在引用块第一位使用 kbd标签后面链接无法正常解析
- Unexpected nested list behavior
- Ordered list is not generated if there's no newline at the end
- Double line breaks (\n\n) are not converted properly HOT 2
- Error using divider with `---` HOT 1
- Empty `<style></style>` or `<style />` causes library to crash
- React 19 incompatibility
- unordered lists don't work
- How to prevent html tag shown when doing streaming
- Nested UL crash rendering
- Feature request: Handle user selection change event in rendered Markdown. Emit an event that returns the corresponding selection in plain Markdown
- include ref property to any div crashes
- type "[key: string]: any" makes extension difficult
- Editing overrides in nested markdown
- Pipe breaks the heading formatting
- Option to provide a custom component as wrapper / pass className to wrapper? HOT 1
- Script tag causes exception
- Trivial RegExp DoS (leading spaces) HOT 2
- parse link incorrectly when both have italic text and link which include '_-'
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from markdown-to-jsx.