Comments (5)
from markdown-to-jsx.
Yeah, discarding the HTML comments is fine - and in fact that's what I think should be the expected behaviour.
In fact, I attempted to use the overrides
option to accomplish this, but was not able to figure out how.
from markdown-to-jsx.
Overrides don't apply for unparseable HTML since it goes through the dangerouslySetInnerHTML
escape hatch and skips the rest of the pipeline. Not the best experience, but it'll have to do for the moment.
I opened up an issue on remark to see if Titus wants to build in first-party support for comments. If not I'll try and work up some sort of regex parsing to drop it. It's a little complicated though because any text around the comment on the same line gets lumped in, so if we simply drop the comment block the text would go too.
from markdown-to-jsx.
That sounds like a good plan.
As far as I am concerned the limitation around stuff surrounding the HTML comment also getting dropped is a non-issue, because I always have them on their own lines.
In fact, I also surround it using empty lines as well,
because some markdown parsers require any HTML tags to do that in order to be treated as HTML instead of markdown.
However, I'm cognizant that not everyone else does the same, so if it is possible, the regex could be used to parse and replace with an empty string rather than drop the line instead. I'm not sure of the internals, so I'm not sure if implementing that is feasible. If it is however, it would break things for less people!
from markdown-to-jsx.
https://github.com/probablyup/markdown-to-jsx/releases/tag/5.4.1 should fix it. Thanks for reporting!
from markdown-to-jsx.
Related Issues (20)
- Cannot access ambient const enums when 'isolatedModules' is enabled. HOT 4
- Cannot render tag if formatted in a certain way. HOT 3
- Supply original string for special case processing HOT 3
- <blockquote> rendering is broken in Firefox after v7.4.0 HOT 2
- Version 7.4.1 has a strange consol.log in index.cjs and index.umd.js - console.log("AHHHHHHHH") HOT 4
- Slow Regex HTML_BLOCK_ELEMENT_R because of issue with self closing tags HOT 5
- Mutli-line bold/italic text not rendering correctly HOT 1
- Support multiline footnotes
- Firefox unable to render link tags HOT 1
- markdown-to-json refuses to work on some aspects HOT 9
- Can't disable HTML sanitization HOT 3
- Component is rendering too frequently, when dependencies have not changed HOT 1
- [Critical] Page freezes with this raw text HOT 4
- Reopen #568
- follow up on #520 HOT 1
- 在引用块第一位使用 kbd标签后面链接无法正常解析
- Unexpected nested list behavior
- Ordered list is not generated if there's no newline at the end
- Double line breaks (\n\n) are not converted properly HOT 2
- Error using divider with `---` HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from markdown-to-jsx.