html comment causes "Error: Invalid tag: --" about markdown-to-jsx HOT 5 CLOSED

from markdown-to-jsx.

Yeah, discarding the HTML comments is fine - and in fact that's what I think should be the expected behaviour.

In fact, I attempted to use the overrides option to accomplish this, but was not able to figure out how.

from markdown-to-jsx.

Overrides don't apply for unparseable HTML since it goes through the dangerouslySetInnerHTML escape hatch and skips the rest of the pipeline. Not the best experience, but it'll have to do for the moment.

I opened up an issue on remark to see if Titus wants to build in first-party support for comments. If not I'll try and work up some sort of regex parsing to drop it. It's a little complicated though because any text around the comment on the same line gets lumped in, so if we simply drop the comment block the text would go too.

from markdown-to-jsx.

That sounds like a good plan.

As far as I am concerned the limitation around stuff surrounding the HTML comment also getting dropped is a non-issue, because I always have them on their own lines.
In fact, I also surround it using empty lines as well,
because some markdown parsers require any HTML tags to do that in order to be treated as HTML instead of markdown.

However, I'm cognizant that not everyone else does the same, so if it is possible, the regex could be used to parse and replace with an empty string rather than drop the line instead. I'm not sure of the internals, so I'm not sure if implementing that is feasible. If it is however, it would break things for less people!

from markdown-to-jsx.

https://github.com/probablyup/markdown-to-jsx/releases/tag/5.4.1 should fix it. Thanks for reporting!

from markdown-to-jsx.