Comments (9)
This looks pretty close to what we merged recently with #997 - Could you compare your implementation with that one and let us know if it would still add any additional features over that implementation or other benefits your implementation might have, that we should improve in the other?
from privatebin.
Ok, so several points seem to be worth improving. I personally would not want to have 2 (or 3, if you count the generic urlshortener implementation) to maintain in the project, especially since I do myself not use this, admittedly popular, feature. I would therefore prefer to a merge request that adds features or rewrites the logic of to the YourlsProxy class.
We deliberately avoid using the curl library, since the request is a very simple one and none of the crafty, advanced curl features should be required in this case - this lets us avoid requiring this extra dependency, keeping the container image sizes small:
PrivateBin/lib/YourlsProxy.php
Lines 62 to 79 in 9614ee9
For the JSON parsing we use a small OOP wrapper, that throws when detecting an error, so we don't forget to check for them:
PrivateBin/lib/YourlsProxy.php
Lines 80 to 86 in 9614ee9
from privatebin.
@ajsap Did you have time to compare your implementation with the existing one? What features do we lack?
from privatebin.
from privatebin.
from privatebin.
Fair enough, take care.
from privatebin.
Also, please don't use ChatGPT to reply to issues or at least tell it not to write it's default longish stuff. And if you did not use it I am sorry, but otherwise please just be transparent about it.
from privatebin.
from privatebin.
Oh I am sorry, I overread it. Especially as email replies (especially with that long signature/addendum) get rendered as very long texts on GitHub. I don't know how accessible GitHub's website is, but if it is possible for you, you could reply here too or so.
And no did not use any software for that, was a pure guessing based on thee writing style. Again I am sorry.
from privatebin.
Related Issues (20)
- SRI error after upgrading due to caching HOT 5
- English language is not selectable since v1.6.1 HOT 2
- Dev Container: "postCreateCommand failed with exit code 126"
- View conf.sample.php and conf.php as INI files by default
- Recurring errors with the creation of pastes HOT 4
- Release could accidentially be triggered when pushing a branch with just number HOT 2
- Safari burns document during automatic preview from highlighting URL HOT 7
- PHP Fatal error: Uncaught Error: Class "Aws\S3\S3Client" not found in .../lib/Data/S3Storage.php:114 HOT 5
- URL shortener support excludes IDNs HOT 6
- Break the glass - get notified if someone uses the link HOT 2
- Blacklisting words option HOT 2
- js/zlib-1.3.wasm 404 (Not Found) HOT 3
- :hourglass_flowing_sand: Document Release Policy HOT 6
- Alignment of file picker dialog in right-to-left languages (RTL) HOT 2
- [Feature Request] Allow for Multi File Uploads HOT 1
- option to see the password HOT 2
- Allow to include third-party scripts from the config file HOT 4
- Making project REUSE compliant (OSS licensing) HOT 2
- Secrets from date HOT 5
- Build reproducibility problem: "git archive" locally results in different .tar.gz than on GitHub HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from privatebin.