Comments (13)
Pritom14
commented on June 12, 2024
Okay, implement it
…On 07-Dec-2017 8:30 AM, "Akshay Nandwana" ***@***.***> wrote:
@Pritom14 <https://github.com/pritom14> Text Input field should be same
everywhere in-app as it looks good on the registration form. We don't
require TextInputLayout in here
I would also like to introduce butterknife for binding in app.
[image: screenshot_2017-12-07-08-23-30-336_com nitsilchar hp
passwordstorage]
<https://user-images.githubusercontent.com/25057618/33696475-60f65368-db28-11e7-9960-a5f9cb106622.png>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#54>, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/APzU4liHvVPPiBTLL5Djtaa0aExovicEks5s91TlgaJpZM4Q4655>
.
from password-storage.
anandwana001
commented on June 12, 2024
@Pritom14 sure
from password-storage.
brijeshshah13
commented on June 12, 2024
@anandwana001 TextInputLayout is necessary for the password visibility toggle feature. I can edit the other EditText in the registration layout to achieve consistency. Okay with you?
from password-storage.
anandwana001
commented on June 12, 2024
@brijeshshah13 I don't think it's necessary because there are many ways we can achieve that toggle button for the password.
from password-storage.
brijeshshah13
commented on June 12, 2024
@anandwana001 I researched about various third party libraries, but they all suggest the use of TextInputLayout after it was launched as an in-built functionality. It is efficient in terms of flexibility and ability to change any prospects in the future.
from password-storage.
anandwana001
commented on June 12, 2024
@brijeshshah13 can we change the design a bit because those background boxes will look ugly with this!
from password-storage.
brijeshshah13
commented on June 12, 2024
@anandwana001 I too thought of it. I will change the background tint to somewhat light so that it blends in and post the screenshot here for review. How about that?
from password-storage.
anandwana001
commented on June 12, 2024
@brijeshshah13 cool lets remove those boxes, update screenshot we can discuss!!
from password-storage.
brijeshshah13
commented on June 12, 2024
@anandwana001 @Pritom14 How about this? Clean and clear. Plus, I have removed the auto-focus from the Email TextInputEditText. Thus, it will get active only when the user clicks to enter the email address.
from password-storage.
Pritom14
commented on June 12, 2024
This looks better
…On 07-Dec-2017 1:33 PM, "Brijesh Shah" ***@***.***> wrote:
@anandwana001 <https://github.com/anandwana001> @Pritom14
<https://github.com/pritom14> How about this?
[image: screenshot-1512633776159]
<https://user-images.githubusercontent.com/18366144/33704628-382d4f92-db53-11e7-82a7-082057844955.jpg>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#54 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/APzU4qP_FynB-7aASX9CsnitQa6jtupjks5s95vpgaJpZM4Q4655>
.
from password-storage.
brijeshshah13
commented on June 12, 2024
@Pritom14 Shall I implement the same in the registration layout as well? Obviously the facility to toggle password visibility will not be embedded there as it will be illogical.
from password-storage.
Pritom14
commented on June 12, 2024
Yes, do it
…On 07-Dec-2017 1:51 PM, "Brijesh Shah" ***@***.***> wrote:
@Pritom14 <https://github.com/pritom14> Shall I implement the same in the
registration layout as well?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#54 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/APzU4k-QH_dgH0oHXB5Y3fTZLMtMPNHUks5s95_4gaJpZM4Q4655>
.
from password-storage.
Pritom14
commented on June 12, 2024
Fixed #55
from password-storage.
Related Issues (20)
- Add all png files in screenshots folder HOT 3
- No functionality to toggle password visibility while logging in HOT 3
- Adding a new feature for password strength HOT 1
- Implementing navigation drawer HOT 7
- Implement option for deletion of account names HOT 2
- Update Readme file HOT 8
- Delete feature HOT 1
- Mark account favorite HOT 1
- Add Account Description HOT 4
- Add Website link
- Implement About Us layout
- Implement Search Button in the Appbar
- Design Settings Layout and Activity
- Design Share Layout and Activity
- Change profile icon and email id as per the user
- On closing the application About Us layout pops up
- Toggle password visibility during registration.
- Gradle and Dependencies outdated. HOT 2
- Update the UI of SignIn and SignUp Activities HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from password-storage.