Code Monkey home page Code Monkey logo

Comments (2)

roblabla avatar roblabla commented on August 16, 2024

roblabla@4d7240b you can cherry-pick this commit to fix this.

from node-minecraft-protocol.

zuazo avatar zuazo commented on August 16, 2024

Thanks for the fix. I have slightly changed the 0x03 packet tests on bdc703a to fix this test error:

  ✖ 1 of 94 tests failed:

  1) packets 0x03:
     TypeError: Cannot read property 'length' of undefined
      at sizeOfString (~/forks/node-minecraft-protocol/lib/protocol.js:1276:18)
      at sizeOf (~/forks/node-minecraft-protocol/lib/protocol.js:1385:12)
      at ~/forks/node-minecraft-protocol/lib/protocol.js:1396:13
      at Array.forEach (native)
      at createPacketBuffer (~/forks/node-minecraft-protocol/lib/protocol.js:1395:10)
      at Client.write (~/forks/node-minecraft-protocol/lib/client.js:92:16)
      at testPacket (~/forks/node-minecraft-protocol/test/test.js:165:12)
      at ~/forks/node-minecraft-protocol/test/test.js:138:9
      at next (~/forks/node-minecraft-protocol/node_modules/batch/index.js:101:5)
      at Batch.end (~/forks/node-minecraft-protocol/node_modules/batch/index.js:129:5)
      at Context.<anonymous> (~/forks/node-minecraft-protocol/test/test.js:143:13)
      at Test.Runnable.run (~/forks/node-minecraft-protocol/node_modules/mocha/lib/runnable.js:196:15)
      at Runner.runTest (~/forks/node-minecraft-protocol/node_modules/mocha/lib/runner.js:344:10)
      at ~/forks/node-minecraft-protocol/node_modules/mocha/lib/runner.js:390:12
      at next (~/forks/node-minecraft-protocol/node_modules/mocha/lib/runner.js:270:14)
      at ~/forks/node-minecraft-protocol/node_modules/mocha/lib/runner.js:279:7
      at next (~/forks/node-minecraft-protocol/node_modules/mocha/lib/runner.js:227:23)
      at Object._onImmediate (~/forks/node-minecraft-protocol/node_modules/mocha/lib/runner.js:247:5)
      at processImmediate [as _immediateCallback] (timers.js:317:15)


npm ERR! Test failed.  See above for more details.
npm ERR! not ok code 0

I will tests this change a bit and I will bump a new version soon. Thanks again 😄

from node-minecraft-protocol.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.