Asset linking issue with sprockets-rails about octicons HOT 7 CLOSED

@tarebyte are you using octicons via sprockets using the instructions provided in the readme, or through some alternative method?

from octicons.

@cameronmcefee I'm using octicons through the instructions on the README for bower with sprockets. My octicons folder is under vendor/assets/bower_components/octicons

These are my configurations:

# config/application.rb

require File.expand_path('../boot', __FILE__)

require 'rails/all'

Bundler.require(*Rails.groups)

module Classroom
  class Application < Rails::Application
    # Do not swallow errors in after_commit/after_rollback callbacks.
    config.active_record.raise_in_transactional_callbacks = true

    # Add bower assets to the path
    config.assets.paths << Rails.root.join('vendor', 'assets', 'bower_components')

    # Precompile Fonts
    config.assets.precompile += %w(*.svg *.eot *.woff *.ttf)
  end
end

// application.css.scss

/*
 *= require octicons/octicons/sprockets-octicons
 *= require_self
 *= require_tree .
 */

@import "primer-css/scss/primer";

from octicons.

@josh would you be able to provide some clarity here? Is this an issue that needs to be resolved in this repo, or is this an implementation-specific issue?

from octicons.

Ugh, this is a sprockets-rails bug (my fault actually). That check should only be applying to image_path helpers in ActionView, not inside Sass font-url itself.

from octicons.

Opened up rails/sprockets-rails#247.

from octicons.

This should be fixed in sprockets-rails 2.3.1.

from octicons.

Updated to sprockets-rails 2.3.1, it now works for me. Thanks @josh!

from octicons.