VirtualScroller: does not update items if only rows length changes about primereact HOT 9 CLOSED

Please fork the Stackblitz project and create a case demonstrating your bug report. This issue will be closed if no activities in 20 days.

from primereact.

added demonstrator projet ( see in issue description "Reproducer")

from primereact.

@mamsellem PR is welcome if you have a recommended fix?

from primereact.

sure. I will submit a PR when possible

from primereact.

Hello I tried to submit a PR from my fork of primereact that it failed with error "you must be a contributor".
This is a screenshot of the submission screen

from primereact.

Weird I have never seen that before it should allow you to open a PR from a fork no problem?

from primereact.

@mamsellem i pushed PR if you want to review.

from primereact.

I don't think using deepequals is a good idea.
We are only interesteed in updating the bounds of the virtual scroller, so only the dimensions of the items matter, not the items themselves.

This was my fix for this issue:

line 570 of VirtualScroll.js

useUpdateEffect(() => {
  if (!prevProps.items || prevProps.items.length !== (props.items || []).length || (both && prevProps.items[0].length !== (props.items ? props.items[0].length : 0))) {
      init();
    }

What do you think ?

from primereact.

as mentioned props.items[0] feels hacky to check the first item of the array length.

from primereact.