Code Monkey home page Code Monkey logo

Comments (7)

melloware avatar melloware commented on September 24, 2024 1

Are you referrring to the Constants? PR is welcome. Updated to PrimeIcons 7.0.0 but did not go through and update all the constants.

from primereact.

inad9300 avatar inad9300 commented on September 24, 2024

@melloware Please, have a look at my comments at https://github.com/primefaces/primereact/pull/6465/files#r1578160473.

from primereact.

melloware avatar melloware commented on September 24, 2024

OK icons fixed. Also if you are concerned any are missing I pulled them right from here: https://github.com/primefaces/primeicons/blob/master/primeicons.css

from primereact.

inad9300 avatar inad9300 commented on September 24, 2024

I would like to insist on the fact that "pi-circle-off", "pi-circle-on" and "pi-file-o" are not part of the documentation. In that sense, primeicons.css seems outdated itself.

Also, both these classes properly separate the word "and":

.pi-arrow-up-right-and-arrow-down-left-from-center
.pi-arrow-down-left-and-arrow-up-right-to-center

Which is not the case with one of their constants:

ARROW_UP_RIGHT_AND_ARROW_DOWN_LEFT_FROM_CENTER
ARROW_DOWN_LEFTANDARROW_UP_RIGHT_TO_CENTER # <-- Missing underscores.

from primereact.

melloware avatar melloware commented on September 24, 2024

I am confused. Are you saying pi circle on is or isn't in primeicons.css. I pulled the CSS directly from the PrimeIcons repo?

from primereact.

inad9300 avatar inad9300 commented on September 24, 2024

I'm saying those three icons aren't listed in https://primereact.org/icons.

from primereact.

melloware avatar melloware commented on September 24, 2024

Looks like the JSON file from PrimeIcons was out of date: https://github.com/primefaces/primeicons/blob/master/selection.json

from primereact.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.