Comments (7)
Are you referrring to the Constants? PR is welcome. Updated to PrimeIcons 7.0.0 but did not go through and update all the constants.
from primereact.
@melloware Please, have a look at my comments at https://github.com/primefaces/primereact/pull/6465/files#r1578160473.
from primereact.
OK icons fixed. Also if you are concerned any are missing I pulled them right from here: https://github.com/primefaces/primeicons/blob/master/primeicons.css
from primereact.
I would like to insist on the fact that "pi-circle-off", "pi-circle-on" and "pi-file-o" are not part of the documentation. In that sense, primeicons.css seems outdated itself.
Also, both these classes properly separate the word "and":
.pi-arrow-up-right-and-arrow-down-left-from-center
.pi-arrow-down-left-and-arrow-up-right-to-center
Which is not the case with one of their constants:
ARROW_UP_RIGHT_AND_ARROW_DOWN_LEFT_FROM_CENTER
ARROW_DOWN_LEFTANDARROW_UP_RIGHT_TO_CENTER # <-- Missing underscores.
from primereact.
I am confused. Are you saying pi circle on is or isn't in primeicons.css. I pulled the CSS directly from the PrimeIcons repo?
from primereact.
I'm saying those three icons aren't listed in https://primereact.org/icons.
from primereact.
Looks like the JSON file from PrimeIcons was out of date: https://github.com/primefaces/primeicons/blob/master/selection.json
from primereact.
Related Issues (20)
- Calendar: Range selectionMode does not allow multi-year (month?) HOT 11
- Missing PT Option for IconField in Password HOT 16
- ListBox Group: Keyboard navigation functions wrong HOT 1
- Calendar - viewDate props - event is null HOT 3
- DataTable: Dynamic column and static column duplicate static column on reorder HOT 6
- Dropdown, Dialog: Blank dropdown when using an array of primary values HOT 13
- Dialog: onHide Called Twice HOT 3
- FontAwesome: Typescript issue passing props HOT 5
- Password: ToggleMask overwrite input width HOT 1
- DataTable: Autocomplete with Dialog on cell editing is not working HOT 4
- DropDown with Groups HOT 3
- InputOTP: Keyboard shortcut paste not working in IntegerOnly HOT 1
- DataTable > Column: It doesn't show operators dropdown and value input when dynamic column is in-place. HOT 1
- AutoComplete Input Passthrough not passing through HOT 4
- Menu: The first item remain focused even after clicking on another item. HOT 3
- Dropdown: Simple primitive values showing empty items HOT 1
- DataTable: Column Reorder Indicator Incorrect
- Calendar: Prop typings are not working correctly HOT 5
- InputNumber: number formatting does not update when locale is set through PrimeReactContext HOT 1
- IconField: Reference error React is not defined, im using vite HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from primereact.