Code Monkey home page Code Monkey logo

Comments (11)

melloware avatar melloware commented on August 24, 2024 2

i think this week sometime. I don't work for PrimeTek...

from primereact.

gucal avatar gucal commented on August 24, 2024 2

Hi there,
We plan to release 10.6.3 today.
Thank you for the feedback.

from primereact.

gucal avatar gucal commented on August 24, 2024 1

Hi,

With release 10.6.3 the issue should be fixed. If you notice that the issue persists, please ping me.

from primereact.

melloware avatar melloware commented on August 24, 2024

@dvpritzbuer can you wait until the next release I am pretty sure all of your issues you are reporting are already fixed.

from primereact.

dvpritzbuer avatar dvpritzbuer commented on August 24, 2024

I mean my first issue today was not already fixed and why shouldn't you take my free feedback even if you just tag it with fixed in 10.6.3?

And this issue here is valid for all new components that use const instead of class (also tested it for IconField) and not only the Stepper!

But ok.. at least in short notice my other bugs as comment:

  • IconField export/import wrong ("primereact/iconfield/iconfield")
  • Stepper documentation example and stackblitz use wrong imports (@/components/lib... instead of primereact/)
  • IconField documentation example uses vue code instead of react

from primereact.

melloware avatar melloware commented on August 24, 2024

IconField already fixed: #6271

What I was saying was in main many things have already been fixed related to Stepper, InputIcon, IconField.

from primereact.

dvpritzbuer avatar dvpritzbuer commented on August 24, 2024

Yeah that's fine, but it's a lot easier for me to just post an issue report instead of searching the code for possible fixes.
Maybe a rough estimate when 10.6.3 will release?

from primereact.

dvpritzbuer avatar dvpritzbuer commented on August 24, 2024

@gucal
This error is not fixed - updated the linked stackblitz.

Also I recognized the original ticket description is not correct since Stepper doesn't have a ref and I just tested it initially with this component since this is a new const type definition.
The stackblitz is now based on InputText.

I have no perfect solution here for you since it would either require the user to write more code or to import another type.

But it would work with this line:
const inputRef2 = useRef<React.ElementRef<typeof InputText>>(null);

So either the user always writes this line himself if using refs within typescript or you export another type like export const type InputTextRef = React.ElementRef<typeof InputText>; and the user has to use this new type then.

Maybe you find a better solution here?

from primereact.

melloware avatar melloware commented on August 24, 2024

Reopened and changed the title.

from primereact.

dvpritzbuer avatar dvpritzbuer commented on August 24, 2024

Ah sorry, I got confused by changing the types within PR #6356 and Stepper not having any ref definition yet, but of course the Stepper also has a ref and the initial title was valid 😅

from primereact.

melloware avatar melloware commented on August 24, 2024

@dvpritzbuer i am confused where are we at with this ticket as of 10.6.5?

from primereact.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.