Comments (11)
@mehmetcetin01140
@cetincakiroglu
I believe that Issue #15837 is invalid and PR #15838 should be reverted.
By reverting PR #15838, this Issue #15851 will be fixed.
To fix issue #15837 the developer should have stopped the event propagation in the button component after a click. Since issue #15837 did not provide a reproducer, I can not completely confirm this.
See the following examples about stopping event propagation:
https://www.w3schools.com/jsref/event_stoppropagation.asp
https://stackoverflow.com/questions/35274028/stop-mouse-event-propagation
https://stackoverflow.com/questions/59993208/how-to-prevent-event-bubbling-in-angular-8
from primeng.
@rosenthalj This is exactly how it should be approached, as anything can be in the header template.
In fact even in the PrimeNg website this error is apparent, the accordion should be opened whenever you click on the header, except cases where the developer deliberately stops the click propagation.
Otherwise there is no workaround, at least that I know of, to replicate the desired behaviour that existed before.
from primeng.
I have upgraded to Angular 18.0.4 and primeNG 17.18.1 and I have the same issue, I.E clicking on text or chevron does not expand/collapse accordion.
However, downgrading to primeNG 17.18.0 or even 17.17.0 does not solve this problem for me.
Be sure to delete package-lock.json file and node_modules folder. Than reinstall (with primeng version 17.18.0) and it should work.
from primeng.
In our application we are using PrimeNG 17.18.0 and Angular v18.0.3 and it's being pretty stable at the moment, this issue is not existing in this version just in version 17.18.1, so I think you should be able to downgrade to version 17.18.0 without any problem and without having to downgrade Angular.
I can confirm that downgrading primeng
to version 17.18.0 does work. The conflicting PR was merged with 17.18.1.
[EDIT]
I'm on Angular version 17:
npx ng version
_ _ ____ _ ___
/ \ _ __ __ _ _ _| | __ _ _ __ / ___| | |_ _|
/ △ \ | '_ \ / _` | | | | |/ _` | '__| | | | | | |
/ ___ \| | | | (_| | |_| | | (_| | | | |___| |___ | |
/_/ \_\_| |_|\__, |\__,_|_|\__,_|_| \____|_____|___|
|___/
Angular CLI: 17.3.6
Node: 20.12.2
Package Manager: npm 10.5.0
OS: win32 x64
Angular: 17.3.6
... animations, cdk, cli, common, compiler, compiler-cli, core
... forms, platform-browser, platform-browser-dynamic, router
Package Version
---------------------------------------------------------
@angular-devkit/architect 0.1703.6
@angular-devkit/build-angular 17.3.6
@angular-devkit/core 17.3.6
@angular-devkit/schematics 17.3.6
@schematics/angular 17.3.6
ng-packagr 17.3.0
rxjs 7.8.1
typescript 5.4.5
zone.js 0.14.4
from primeng.
Issue #15859 is a duplicate of this Issue #15851
PR #15867 fixes this Issue #15851 and Issue #15859.
PR #15867 reverts PR #15838 which broke the Accordion Header functionality
from primeng.
Any ETA? we have already migrated to Angular 18 and downgrading to v17.17 seems quite annoying now.
Likely we are not in production yet but the QA team is doing a few tests.
So thanks.
from primeng.
Any ETA? we have already migrated to Angular 18 and downgrading to v17.17 seems quite annoying now. Likely we are not in production yet but the QA team is doing a few tests.
So thanks.
In our application we are using PrimeNG 17.18.0 and Angular v18.0.3 and it's being pretty stable at the moment, this issue is not existing in this version just in version 17.18.1, so I think you should be able to downgrade to version 17.18.0 without any problem and without having to downgrade Angular.
from primeng.
Thanks @adri95cadiz I have to check again because QA reported the same issue even with version 17.18.0
from primeng.
same happened with me today
from primeng.
I have upgraded to Angular 18.0.4 and primeNG 17.18.1 and I have the same issue, I.E clicking on text or chevron does not expand/collapse accordion.
However, downgrading to primeNG 17.18.0 or even 17.17.0 does not solve this problem for me.
from primeng.
I have upgraded to Angular 18.0.4 and primeNG 17.18.1 and I have the same issue, I.E clicking on text or chevron does not expand/collapse accordion.
However, downgrading to primeNG 17.18.0 or even 17.17.0 does not solve this problem for me.Be sure to delete package-lock.json file and node_modules folder. Than reinstall (with primeng version 17.18.0) and it should work.
Thanks, you are right.
from primeng.
Related Issues (20)
- Autocomplete: "[object Object]" displayed when optionLabel input is used and the computed label value is null or undefined HOT 2
- pFocusTrap: "aria-hidden-focus" accessibility rule violation
- RadioButton | Remove label & labelStyleClass
- Remove SlideMenu Component
- Menubar: Positioning of sub-menus goes off screen
- P-Chart: Chart Width & Height not working with 17.18.4 HOT 2
- p-dropdown with editable=true and floating labels doesn't work with manually entered values
- p-dropdown: Panel not positioned correctly under some specific filter circumstances HOT 1
- Issue with LsitBox and style since 17.18.4 HOT 1
- MultiSelect and Listbox filterby is not working
- 17.6.15 Build failed
- Tree: inputText in Template mode does not respond to a space key
- ListBox | Add Checkmark and checkmarkTemplate
- Sort not working for nested dynamic columns in table HOT 3
- p-selectButton Not Selecting Default Option Value HOT 2
- Autocomplete: with virtual scroll and item selected, it doesn't show items in dropdown and doesn't keep the selected item position when scrolling
- Button | Add focus() method
- Menu: Popup menu cannot be opened on a different target when it is already opened
- Component: Table, when I try add a custom icon doesn't work
- p-inputnumber: Not allowing to start the decimal with DOT(.)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from primeng.