Code Monkey home page Code Monkey logo

Comments (3)

rosenthalj avatar rosenthalj commented on June 27, 2024

This bug was created when issue #15557 was attempted to be fixed by PR #15594. The issue of clearing the filters when a user doesn't apply the filter is very complicated. I have known about this PrimeNG issue for multiple years and believed there was no straight forward fix. i have spent a few hours trying to see if i could improve the changes introduced by PR #15594 and have failed to find a solution that both fixes this issue #15804 and at a minimum partially fixes #15557. The problem is that there are more than one advance filter (strings, date, multi-select, ...) and they all work slightly differently. Also, there are APIs provided by PrimeNG table that allow a developer to programmatically clear/reset filters. I believe the best short term solution is to just revert the changes made in PR#15594 until a "real" expert can fix this functionality.

from primeng.

rosenthalj avatar rosenthalj commented on June 27, 2024

I just reviewed issue: Component: Table (Advanced Filter) #15778. It's similar to the this issue, but not identical. I also confirmed that the problem was caused by the changes made to PR#15594

from primeng.

RogueTea avatar RogueTea commented on June 27, 2024

Hello, I'm currently looking into this and I think I have a rough solution but would be great to hear your thoughts.
Link to the draft PR
Some more manual testing, code cleanup and unit test needs to be done but It would be great to get some more eyes on it.

from primeng.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.