Comments (3)
This bug was created when issue #15557 was attempted to be fixed by PR #15594. The issue of clearing the filters when a user doesn't apply the filter is very complicated. I have known about this PrimeNG issue for multiple years and believed there was no straight forward fix. i have spent a few hours trying to see if i could improve the changes introduced by PR #15594 and have failed to find a solution that both fixes this issue #15804 and at a minimum partially fixes #15557. The problem is that there are more than one advance filter (strings, date, multi-select, ...) and they all work slightly differently. Also, there are APIs provided by PrimeNG table that allow a developer to programmatically clear/reset filters. I believe the best short term solution is to just revert the changes made in PR#15594 until a "real" expert can fix this functionality.
from primeng.
I just reviewed issue: Component: Table (Advanced Filter) #15778. It's similar to the this issue, but not identical. I also confirmed that the problem was caused by the changes made to PR#15594
from primeng.
Hello, I'm currently looking into this and I think I have a rough solution but would be great to hear your thoughts.
Link to the draft PR
Some more manual testing, code cleanup and unit test needs to be done but It would be great to get some more eyes on it.
from primeng.
Related Issues (20)
- markAllAsTouched not firing
- SplitButton: Broken in RTL mode HOT 1
- Password: Wrong icon for show/hide password toggle
- Dialog is not draggable via touch
- Accessibility within Tree Component
- Accessibility: Tree inside an Accordion (arrow navigation)
- MultiSelect: changes in selectedItemsLabel input are not updated
- Component: Carousel. When you add an item to the list, container gets wrong estimation for transform css prop HOT 1
- Calendar: showClear with showIcon & [iconDisplay]="'input'" makes the clear button float
- Dropdown: when using the mouse to scroll down the dropdown the scrollbar-thumb slides away from the mouse pointer.
- Accessibility: Buttons within an accordion header template (keyboard accessibility)
- Dropdown: options in cleared if initialized during component constructor
- Calendar: Popup appears partly offscreen even when there's enough vertical space
- Multiselect: selectionLimit not working HOT 1
- Component: calendar component doesn't display the clear icon properly in certain conditions HOT 1
- Component: Table. Resizable columns with column grouping
- InputOtp: Android Phones - MoveToNext is not called after input
- InputOtp: Build in paste functionality does not work to paste more than one character in the InputOtp
- Button with Icon Only does not render well when used with badge HOT 1
- Calendar: When focused on the `Choose Month` and `Choose Year` buttons with a screen-reader, it should also read the selected value
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from primeng.