Infer options from eslint-plugin-prettier about prettier-eslint HOT 13 CLOSED

Yeah, that was it. Turned out I had an older prettier version installed globally (0.18) and in the package.json was prettier-eslint 4.1.1. I did have to tweak my Webstorm config a bit (a file watcher that runs prettier-eslint-cli on save of any js files). But it seems to work properly now!

from prettier-eslint.

from prettier-eslint.

Can you post a screenshot of your settings?

If you're using the CLI, this may be nice to document in the prettier-eslint-cli docs too...

from prettier-eslint.

Could you update your version of prettier-eslint-cli and run it again (without TRACE)? This should surface the underlying error now.

from prettier-eslint.

Thanks, I tried again. I get:

Validation Error:

      Option "trailingComma" must be of type:
        boolean
      but instead received:
        string

      Example:
      {
        "trailingComma": false
      }

I am using eslint-plugin-prettier also. Like I said, I have this rule in my .eslintrc:

"prettier/prettier": [
	"error",
	{
		"trailingComma": "all",
		"singleQuote": true,
		"printWidth": 120
	
	}
]

I did give it a try using true instead of "all", but that doesn't help (and doesn't follow the prettier docs).

from prettier-eslint.

Huh, it looks like you have an old version of prettier. Are you sure you upgraded to the latest version? In any case, you'll also want to note the technical details section because eslint-plugin-prettier rules are not currently supported in the inference capabilities of prettier-eslint. We should definitely support them though. Would you like to makeapullrequest.com?

from prettier-eslint.

Cool. Just so you know, prettier-eslint is still unable to determine the best prettier options based on your config. Would you like to add support for inferring options from eslint-plugin-prettier config?

from prettier-eslint.

I did have to tweak my Webstorm config a bit (a file watcher that runs prettier-eslint-cli on save of any js files)

@im-martijn How did you configure this exactly? This sounds like what we need...

from prettier-eslint.

from prettier-eslint.

Oh ok, so you're not using prettier-eslint-cli right now? You're just using prettier directly? I assume you set it up like this... https://github.com/prettier/prettier/blob/4babc032cbf98876ef97801238ce65f04ea6db14/editors/webstorm/README.md#using-file-watcher

In WebStorm does prettier alone also integrate with eslint --fix like in Atom?

from prettier-eslint.

That's more or less what I did. I also adapted the scope of files to watch. I also added arguments for single quotes, trailing commas, flow parser and print width. For the output paths to refresh I have $FileDir$. I did not set the working directory to anything at all. Well, it works for me.

from prettier-eslint.

If we infer from eslint-plugin-prettier I do think that prettier configuration in prettier/prettier should be used and the options not present in this rules' config should be inferred from the other rules.

This basically means that all functions that resolves an eslint option to a prettier option needs to look at prettier/prettier first, unless i can do this check before this logic runs.

from prettier-eslint.

Ability to infer prettier config from eslint-plugin-prettiers prettier/prettier rule is supported since 5bd3684 and is release with 8.6.0.

from prettier-eslint.