`comma-dangle` "off" with object option is not working properly. about prettier-eslint HOT 3 CLOSED

Happy to accept a pull request 😄

from prettier-eslint.

Thanks for the detailed issue! It's unlikely I'll have time to dedicate to hunting down the core issue. If you could do a little more digging and propose a solution that would be helpful. Thanks!

from prettier-eslint.

The short answer is, that this issue can be resolved by changing the line https://github.com/prettier/prettier-eslint/blob/master/src/utils.js#L211 with

const [, {arrays = '', objects = '', functions = ''} = {}] = objectConfig

...giving the destructured object a default value. (made that change but the jest --coverage kept failing and I'm not familiar with the underlying test suites and how to quickly fix the coverage test, but happy to dig through that if you have a few pointers).

The larger question is about error handling. I got here from this issue: prettier/prettier-atom#231 (comment) , an atom-plugin. prettier-eslint was throwing an error that bubbled through the plugin and was a little bit hard to decipher. Part of the problem being a missing stack trace in the recent versions of Atom and/or the plugin.

What do you think about an error handling system that produces slightly more verbose or even "human readable" messages (e.g. especially useful for Atom users)?

from prettier-eslint.