prettier-eslint-cli does not throw eslint's errors about prettier-eslint-cli HOT 5 CLOSED

Our tree is large and it would be nice to only have to run one tool to format the files when nothing else is wrong, but that would throw when other eslint rules are violated so we don't need to run the expensive operation against the entire tree twice. I can understand that it's not the default behavior, but it seems reasonable to allow that as a configuration.

from prettier-eslint-cli.

Hi @arfa, 👋

That phrase in the docs is referring to errors thrown (like when parsing), not errors in the rules. prettier-eslint is focused only on formatting things that can be formatted, not about reporting rule violations. It is intended to be used completely separately from eslint (you should have both).

So you use prettier-eslint to autoformat your code, and eslint to find issues which cannot be autofixed.

I hope that helps.

from prettier-eslint-cli.

Hi @kentcdodds

Thanks you for your response. it is clear now 👍

Maybe you should specify that in the docs.
I think it is important to know that we should have both.

from prettier-eslint-cli.

Agreed. Would you like to makeapullrequest.com? 😄

from prettier-eslint-cli.

I will do it 😄

It will be a PR on prettier-eslint

from prettier-eslint-cli.