Code Monkey home page Code Monkey logo

Comments (4)

fisker avatar fisker commented on May 21, 2024 1

Point to the hash, if you don't want update.

It's not pinned tag, it's Prettier version, we do updates even Prettier has no new version.

from pre-commit.

graingert avatar graingert commented on May 21, 2024 1

@bgusach this is now fixed in https://github.com/pre-commit/mirrors-prettier

from pre-commit.

fisker avatar fisker commented on May 21, 2024

Any problem?

from pre-commit.

bgusach avatar bgusach commented on May 21, 2024

Well, yes... generally speaking versions are pinned in order to avoid unexpected changes. Per definition, a branch is not a specific version. A hash or a well respected tag is.

If I refer to a branch instead of a tag, my code may work today but tomorrow somebody pushes something new, exciting and broken and boom there you go, I have a headache. I don't like headaches 😅.

And not unexpectedly, this doesn't work with pre-commit autoupdate as it just fetches the hash of main, because of the aforementioned lack of tags:

> pre-commit autoupdate --repo https://github.com/prettier/pre-commit
Updating https://github.com/prettier/pre-commit ... [INFO] Initializing environment for https://github.com/prettier/pre-commit.
updating v2.1.1 -> 36b76b1cf9df45924c11f7a06756a12c9f6cf6c2.

from pre-commit.

Related Issues (9)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.