Invalid trailing comma with trailingComma: true about plugin-ruby HOT 8 CLOSED

I'm running into this issue when using prettier-vscode.

I think the issue might be a conflict between prettier's default trailingComma value, which is "none", and plugin-ruby expects a boolean value.

Adding trailingComma: <boolean> to the prettier config seems to fix it for me, but I think this breaks other stuff in regards to JS formatting.

from plugin-ruby.

Here's a minimum repro:

$ mkdir test && cd test
$ npm init -y
$ npm install --save-dev prettier @prettier/plugin-ruby
$ ./node_modules/.bin/prettier --support-info
$ # [error] Invalid trailingComma value. Expected true or false, but received "none".

from plugin-ruby.

I think a solution would be values of "none" and "always" for trailingComma instead of true/false.

from plugin-ruby.

I think this is a seprare issue. As you can see above, the comma is applied in my example but the resulting ruby is invalid. That's different than the option not being respected at all

from plugin-ruby.

This is gonna be fixed with #87

from plugin-ruby.

Now fixed on master

from plugin-ruby.

Now fixed on v0.4.1

from plugin-ruby.

Thanks @kddeisz !

from plugin-ruby.