Registers should be defined as unions of bit-struct and u16 about pokeruby HOT 5 OPEN

Some of the code does use a bitfield, but other parts assign the values directly, and using a bitfield won't match. We already have a vBgCnt struct in types.h for this.

from pokeruby.

Exactly, which is why they should be defined as unions. It's good to know these are already defined in types.h, so I don't need to redefine them. Additionally, do_boulder_dust also uses the DMA3 registers as structs of 3 u16s:

    REG_DMA3.SAD = (u32) &var_c;
    REG_DMA3.DAD = r1;
    REG_DMA3.CNT = 0x85000400;

from pokeruby.

Isnt that just a DmaFill32 ? Please use the macros defined in gba/macros.h

from pokeruby.

Turns out it is, thanks!

from pokeruby.

Oh, I see what you mean about making it a union. I believe that would match at the cost of being slightly more verbose because of the extra member required. If there's a significant amount of code that accesses it as a bitfield, then the change is probably worth it. If the vast majority of code accesses it as a raw u16, then it might be good to leave it as it is.

from pokeruby.