String length defines about pokeemerald HOT 4 CLOSED

If I'm not mistaken, the player's name can only be a max of 7 chars but takes up 8 with its EOS, but the POKEMON_NAME_LENGTH can be a max of 10 chars, foregoing the EOS entirely with a hardcoded maximum length. The defines are weird because the game is weird, but you're right that they should be standardized somehow.

from pokeemerald.

I suggest if the string uses EOS, which is the common case, define the length not including the EOS, and then add one to the buffer size.

#define EXAMPLE_NAME_LENGTH 10
u8 exampleName[EXAMPLE_NAME_LENGTH + 1];  // 11 bytes in size

If it's not terminated with EOS, then just don't add the +1

#define EXAMPLE_NAME_LENGTH 10
u8 exampleName[EXAMPLE_NAME_LENGTH];  // 10 bytes in size

from pokeemerald.

So can this be closed?

from pokeemerald.

It didn't get resolved, the issue is still there

from pokeemerald.