Comments (6)
Hello everyone,
Here is a list of common feedbacks we received from the community, we need to try to reduce these pains as much as possible, so when someone takes an issue, please try to think about it:
- Bootstrap 5
- Good structure inside
src
directory, which was_dev
before - No more core.js file, everything in the theme (with an exported library organised as services in order to achieve some API calls)
- Lazyloading everywhere
- Good CSS/classes names, BEM-like. Product list is a good example if you want to collapses to it
- Use a reused variable for the first part of every component classes, in smarty AND inside scss, so we're able to rename it easily.
- JSON-LD
- Think about adding hooks, because it looks like some are missing
- Try to make it as clean as possible with only bootstrap 5, then integrate the custom mods inside the custom folder, so it's easy to remove and looks clean without custom styles
- Don't add unneeded dependencies, bootstrap should almost be enough for everything such as sliders and other components
- If you working on JS, don't use jQuery, we will keep it for retrocompatibility with some modules but we won't use it as JavaScript is enough now.
- We should try to get rid of these API reloading some markup content, if you face this problem, please create an issue so we'll try to negotiate some endpoints in order to go further
- Add as much event as possible on JS important features, so theme and module developers are able to play with these events
- Try to use as much bootstrap components as possible.
- Get rid of JQuery UI
- If you develop a custom component (such as product list, small product for example), please create his own files/scss sheets, and reuse it instead of repeating code.
Here is how the theme looks for the moment, before Scott reworked a lof of mockups:
And if you remove custom styles, you've a raw bootstrap 5 theme structure
from hummingbird.
It is very important that the template is light and well optimized, especially for mobile devices, because the most users use mobile devices.
from hummingbird.
The template should also be built on Grid CSS or flexbox. I would also use a maximum of one font Light 300, Regular 400, Bold 700. It's also good if the fonts are in the template folder, not using a link, e.g. from google. Will you be using bootstrap icons?
For the moment, almost everything is using bootstrap row/columns system, so basically it's using flexbox everywhere, product list for example is based on bootstrap columns only, which wasn't the case before...
We use material icons as a choice from @prestascott because anyway, bootstrap icons are not imported by default, and it's retrocompatible !
Don't hesitate to create an issue about your thought or contribute to the project :)
from hummingbird.
It's seems that somes are missing as:
- Sitemap
- Contact us
- Store page
Also inside the account, the kind of module as blockwishlist (Don't know if it will be shipped again and if the theme need to handle it or it's the module itself, there).
from hummingbird.
Current workflow
- Build everything in an initial phase to 95% completion
- Do major cleanup of code
- Recheck everything and polish everything to be exactly to the mockup. Discuss inconsitencies.
- Check with community and discuss what level of "basic" they want the theme to look like with custom styles removed.
- Then, remove as much code from "core" to "custom" until it breaks.
- Check that we didn't remove any modding capabilities. Add some if possible.
cc @NeOMakinG
from hummingbird.
The template should also be built on Grid CSS or flexbox. I would also use a maximum of one font Light 300, Regular 400, Bold 700. It's also good if the fonts are in the template folder, not using a link, e.g. from google. Will you be using bootstrap icons?
from hummingbird.
Related Issues (20)
- [FO] Bad display in the prices filters while uncheck one of the filters
- [Shopping Cart] the price is displayed twice as if there was a discount HOT 1
- [Shopping Cart] when you edit the product qty to zero, the product won't be removed from the cart
- Improve "First Input Delay"
- [Shopping Cart] quantity input of additional products have an issue after changing quantity of a product in the cart
- The click on the lens of the search box doesn't work HOT 3
- Verify that external modules can extend checkout process HOT 1
- [FO] PRODUCT CARD - Wrong behavior when we change minimum for order
- Unusable menu dropdown when store logo is tall
- Add a redirect button to the home page in the error page
- Three hooks don't work on the hummingbird theme
- Variants display problem on product page HOT 2
- Contact Information module's Email address is not shown HOT 2
- Unable to run "npm run build" HOT 3
- Really strange scrolling issue when paging with firefox HOT 2
- Mobile product list changes between one product per "line" and two products per line HOT 3
- In quick view, magnifying glass on product doesn't work, the modal is directly closed.
- Product reference only shown if manufacturer is set
- Light / Dark theme
- Sticky header
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hummingbird.