Add ability to override S3 endpoint_url about prefect-aws HOT 5 CLOSED

I think strongly typed Dataclasses are preferable for the DX as long as the type they're representing is relatively stable.

from prefect-aws.

Sounds like an excellent addition @davzucky and I'd be happy to review a PR for this contribution! I would recommend adding an attribute to the AwsCredentials class that can be used to pass additional configuration when creating a boto3 session. Let me know if you need any help!

from prefect-aws.

I'm debating if that extra option should be with the AwsCredential or not. The main point is that AwsCredential are used to create the session, however, these extra params would be used for the client initialization. Should it be another input to the functions?

from prefect-aws.

Yeah, I think it should be another input the the S3 tasks. I wanted to be able to accept those additional options one place so that we wouldn't have to duplicate those options across all the S3 tasks, but since these are client level options it makes more sense for them to be on the tasks.

from prefect-aws.

ok, So we are on the same page. Let me prepare that. Do you prefer a strongly type dataclass with all the params, or just taking a generic dict as kwargs_s3 ?

from prefect-aws.