allow user to disable gitignore update about spades.project HOT 15 CLOSED

thank you! this looks like it's working.

from spades.project.

It isn't supposed to be overwriting .gitignore. Can you describe what you are observing? It is only modifying two lines... packagePath and modulePath, which I think is the correct behaviour. It doesn't touch anything else.

from spades.project.

Perhaps a reprex?

from spades.project.

Neither of those should be touched, so I want to turn this off.

1. packagePath may not be a project subdirectory, so it doesn't make sense to add it here (it's also incorrect in this case in that it adds 4.2 to .gitignore and not the main package directory).

pkgDir <- file.path(tools::R_user_dir(basename(prjDir), "data"), "packages",
                        version$platform, getRversion()[, 1:2])

2. modulePath may contain git submodules. Adding it to the project .gitignore doesn't make sense, and may prevent changes in those modules or new modules from being properly registered.

from spades.project.

can this please be merged asap? it is fully backwards compatible: the default behaviour is the same. it only changes if the user sets the option SpaDES.project.updateGitIgnore = FALSE.

from spades.project.

I've updated the pending PR (#25) with the latest changes on the transition branch, and tested. It's ready to go.

from spades.project.

This PR is building a work around that is not the correct solution. I will try to make the correct solution now.

from spades.project.

FYI: there are 3 use cases:

1. Users not using git
2. Users using git, but only for the modules (i.e., not a git repo with git submodules)
3. Users using git submodule infrastructure, where modules are themselves (possibly) git repositories.

The solution provided in this PR only deals with the 2nd and 3rd cases, as an option. This leaves it in the realm of secret handshake (i.e., if you know what you need to know, then it will work), which I am trying to not use.

from spades.project.

yes, this is a quick workaround until a more throrough solution is implmented and tested. reviewing every commit made to a shared repo and restoring .gitignore to it's original state (because of inadvertant commits) is taking more time than it needs to when we can simply turn off this behaviour for now.

from spades.project.

The transitions branch of SpaDES.project is not for work arounds. It is "a complete solution without work arounds". I have pushed something that deals with the 3 cases.

from spades.project.

It is working for cases 1 and 3 above. Testing 2.

from spades.project.

Minor tweaks for Test Case 2. Working for that too now.

from spades.project.

hmmm it's not quite there yet. .gitignore being modified again.

from spades.project.

from spades.project.

Yes, using latest version (only a single version, in project-specific dir). It's not happening everytime I run things though.

from spades.project.