Comments (15)
thank you! this looks like it's working.
from spades.project.
It isn't supposed to be overwriting .gitignore
. Can you describe what you are observing? It is only modifying two lines... packagePath
and modulePath
, which I think is the correct behaviour. It doesn't touch anything else.
from spades.project.
Perhaps a reprex
?
from spades.project.
Neither of those should be touched, so I want to turn this off.
packagePath
may not be a project subdirectory, so it doesn't make sense to add it here (it's also incorrect in this case in that it adds4.2
to.gitignore
and not the main package directory).
pkgDir <- file.path(tools::R_user_dir(basename(prjDir), "data"), "packages",
version$platform, getRversion()[, 1:2])
modulePath
may contain git submodules. Adding it to the project.gitignore
doesn't make sense, and may prevent changes in those modules or new modules from being properly registered.
from spades.project.
can this please be merged asap? it is fully backwards compatible: the default behaviour is the same. it only changes if the user sets the option SpaDES.project.updateGitIgnore = FALSE
.
from spades.project.
I've updated the pending PR (#25) with the latest changes on the transition
branch, and tested. It's ready to go.
from spades.project.
This PR is building a work around that is not the correct solution. I will try to make the correct solution now.
from spades.project.
FYI: there are 3 use cases:
- Users not using
git
- Users using git, but only for the modules (i.e., not a git repo with git submodules)
- Users using git submodule infrastructure, where modules are themselves (possibly) git repositories.
The solution provided in this PR only deals with the 2nd and 3rd cases, as an option. This leaves it in the realm of secret handshake (i.e., if you know what you need to know, then it will work), which I am trying to not use.
from spades.project.
yes, this is a quick workaround until a more throrough solution is implmented and tested. reviewing every commit made to a shared repo and restoring .gitignore
to it's original state (because of inadvertant commits) is taking more time than it needs to when we can simply turn off this behaviour for now.
from spades.project.
The transitions
branch of SpaDES.project
is not for work arounds. It is "a complete solution without work arounds". I have pushed something that deals with the 3 cases.
from spades.project.
It is working for cases 1 and 3 above. Testing 2.
from spades.project.
Minor tweaks for Test Case 2. Working for that too now.
from spades.project.
hmmm it's not quite there yet. .gitignore being modified again.
from spades.project.
from spades.project.
Yes, using latest version (only a single version, in project-specific dir). It's not happening everytime I run things though.
from spades.project.
Related Issues (20)
- store previous libPaths in the object output by setupProject()
- checking absolute paths
- 2 different `data.table`-related errors HOT 6
- `setupSideEffects` and `setupOptions` have the same description HOT 1
- `setupProject` examples have an error? HOT 1
- `setupProject(..., Restart = TRUE)` creates RStudio project, but `setupProject(..., Restart = FALSE)` doesn't HOT 2
- strange output/behaviour when `setupProject(..., verbose = 2)` HOT 1
- Object missing from output of `setupProject`: partial matching issue? HOT 2
- `setupProject(..., sideEffects)` documentation seems circular and may ned more detail HOT 2
- separate `setupProject` documentation from `setupStudyArea` and other "inner" funtions
- setupProject is not finding the url although it can be opened in the browser HOT 1
- `Error in (function (nam) : argument "valObjName" is missing, with no default` HOT 2
- The main project is not being set up properly as a git repo when using `useGit="Sub"`. HOT 4
- Pkg installation issues HOT 2
- `tools::file_ext(modules)` returns "R" not ".R"
- `parseFileLists` can't find `defineModule()`/`defineParameter()` but they are there? HOT 3
- `setupModule` with GitHub .R file - errors are misleading and module ends up in "wrong place" HOT 3
- Issue using `setupProject` to prepare for spades workshop HOT 10
- Can no longer pass a `list` to modules HOT 1
- Fix messaging for downloaded module paths
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from spades.project.