Code Monkey home page Code Monkey logo

Comments (8)

achubaty avatar achubaty commented on June 28, 2024 1

Thanks @CeresBarros! The overwrite arg is passed to write_disk inside the GET call; see the example Eliot used in the first message in this thread. It sounds like you used it correctly. I'll review the PR later tonight.

from spades.core.

achubaty avatar achubaty commented on June 28, 2024

NOTE: download.file already overwrites by default

from spades.core.

eliotmcintire avatar eliotmcintire commented on June 28, 2024

presumably a FALSE is also relevant, thus the need for argument

from spades.core.

achubaty avatar achubaty commented on June 28, 2024

from spades.core.

CeresBarros avatar CeresBarros commented on June 28, 2024

I've added an overwrite option to downloadModule and opened a PR. There seem to be two minor conflicts (which I think I solved?) on the .R and .Rd files for downloadModules.
I've also tried to clarify the documentation of getModuleVersion, as I felt it wasn't clear where the version was being extracted from.

from spades.core.

CeresBarros avatar CeresBarros commented on June 28, 2024

Also, in response to Alex's last comment: are you sure the overwrite option can be passed to GET? I've passed if to write_disk in downloadModule, because I couldn't find an overwrite option in GET.

from spades.core.

achubaty avatar achubaty commented on June 28, 2024

@CeresBarros did you also add it to downoladData?

from spades.core.

CeresBarros avatar CeresBarros commented on June 28, 2024

Nop, but if overwrite passes from GET to write_disk I'll do it :)

from spades.core.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.