Comments (4)
jrose-signal
commented on June 4, 2024
1
That would be fine too! Honestly the biggest problem is that it's displayed as an Error (of course it is, that's what was thrown), and someone who doesn't know about node-gyp-build might think that's an actual error during the build process rather than just part of the detection logic.
from node-gyp-build.
mafintosh
commented on June 4, 2024
What's your suggestion for updating this? Not fully sure I follow. If users use the node-gyp-build cli it will fallback to classic npm behaivour of building the source if no prebuild works - you can disable this with the --optional flag. Are you saying we should never do that?
from node-gyp-build.
jrose-signal
commented on June 4, 2024
No, no! I'm saying it's worth taking extra steps to avoid printing the error, even in --verbose mode. The actual behavior is good.
from node-gyp-build.
vweevers
commented on June 4, 2024
I've found it useful many times. Would it help to tweak the message?
from node-gyp-build.
Related Issues (20)
- node-gyp-build sometimes hangs when it has no work to do with node 12 HOT 2
- The loading algorithm doesn't work for Webpack-bundled applications when dependencies are bundled into them. HOT 17
- Optional exit with 0 if build fail? HOT 3
- require in node-gyp-build-test causes prebuild detection to fail HOT 3
- documentation missing for multiple features HOT 2
- getting error node-gyp-build HOT 7
- Understanding if prebuilds are being used or not HOT 3
- Cross platform prebuild HOT 4
- question: is node-gyp required as a dependency? HOT 4
- Add support for node-webkit runtime HOT 1
- Load from generated metadata
- Failure to find prebuild on Linux 5.11.0-1022-aws HOT 1
- Error: No native build was found HOT 1
- "No native build was found" for `node-gyp-build` when bundling with `esbuild` HOT 3
- Report more information when a prebuild is not found HOT 6
- npm ERR! command sh -c node-gyp-build - Error While Installing Hardhat HOT 1
- Building fails on node v20 when using yarn HOT 5
- npm workspaces path issues
- Critical dependency: require function is used in a way in which dependencies cannot be statically extracted HOT 17
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from node-gyp-build.