Crash on exit about pragha HOT 30 CLOSED

Honestly, it seems logic since the conversion to GtkApplication, but I can not reproduce it..

How close Pragha? (Using a menu?, Or how else?)

Thanks for the report, ;)
Regards.

from pragha.

How close Pragha?

Either right click on the icon or just closing the window directly if the tray icon is disabled.

from pragha.

Hey,
Do not can reproduce it, but considering all of the changes seem possible. Now keep investigating ;)

from pragha.

@TingPing
Still can not reproduce it.

You use fedora? and the log is ABRT?

Please make a backtrace directly with gdb and atach it here..

gdb src/pragha

run

(expects break)

bt

..and remembers configure the compilation with the option --enable-debug

from pragha.

You use fedora?

Fedora rawhide.

and the log is ABRT?

No what I pasted from above is the gdb output.

from pragha.

No what I pasted from above is the gdb output.

D'Oh!. Ok. I'll have to test Gtk3.12.

Hi @rat4
You always got most updated packages. Can you reproduce this?

from pragha.

@matiasdelellis updated to git master, it seems very unstable, including this crash

from pragha.

Ohhh... Okey.. 😕

Please. Test reverting the b99cf42 commit.

Here working properly.. Very strange.

from pragha.

Didn't change anything

from pragha.

Ok. So is related to any of the changes (and lots of Hacks!) I made before.

Now download a more updated distro to investigate..

it seems very unstable

What others problems you found?

from pragha.

Biscted, first bad commit is 327aa3f
Maybe bug in GTK 3.12?

from pragha.

Biscted, first bad commit is 327aa3f

I also tested reversing this commit, and again not save preferences, but with or without it, here not broken. Might we have to revert this, and do it better.

Maybe bug in GTK 3.12?

So probably.
Just look at all commits GtkApplication, and not found any significant change.
While download Xubuntu Beta2 to test it, now I'm watching all reported bugs from Gtk 3.9 to 3.12.

from pragha.

I think I found the source of the issue:
https://developer.gnome.org/gtk3/stable/GtkWindow.html#GtkWindow--application

Basically, while destroying the window again call dispose!.

.pragha_dispose () {
.... .
. if (main_window) {
. gtk_widget_destroy (mainwindow);
. => pragha_dispose () {
. if (main_window) { // Still not null.
. gtk_widget_destroy (mainwindow); // CRASSHHH!!
. }
. mainwindow = NULL; // LATERRRRRRRRRRRRRRRRRRR

But not explain why works for me!. 😓

from pragha.

Well.. Please.. test last commit.. 😴

Regards.

from pragha.

@matiasdelellis You fixed the crash but I get a lot of warnings on exit:

(pragha:27830): GLib-GObject-WARNING **: invalid unclassed pointer in cast to 'GObject'
(pragha:27830): GLib-GObject-WARNING **: instance with invalid (NULL) class pointer
(pragha:27830): GLib-GObject-CRITICAL **: g_signal_handler_disconnect: assertion 'G_TYPE_CHECK_INSTANCE (instance)' failed
(pragha:27830): GLib-GObject-WARNING **: instance with invalid (NULL) class pointer
(pragha:27830): GLib-GObject-CRITICAL **: g_signal_handlers_disconnect_matched: assertion 'G_TYPE_CHECK_INSTANCE (instance)' failed
(pragha:27830): GLib-GObject-WARNING **: invalid unclassed pointer in cast to 'GtkContainer'
(pragha:27830): Gtk-CRITICAL **: gtk_container_remove: assertion 'GTK_IS_CONTAINER (container)' failed
(pragha:27830): GLib-GObject-WARNING **: invalid unclassed pointer in cast to 'GtkContainer'
(pragha:27830): Gtk-CRITICAL **: gtk_container_foreach: assertion 'GTK_IS_CONTAINER (container)' failed
(pragha:27830): Gtk-CRITICAL **: gtk_widget_hide: assertion 'GTK_IS_WIDGET (widget)' failed

from pragha.

D'Oh!. 😓

Test comment the line:

g_object_run_dispose (G_OBJECT (pragha));

..in pragha.c

from pragha.

@matiasdelellis That worked.

from pragha.

Ohhh... Ignore last comment!!1.

Is due to the plugins!. Now fix it!

from pragha.

g_object_run_dispose (G_OBJECT (pragha));

That worked.

WTF?. hahaha.. maybe it works but you lose all changes in preferences .. etc. ;)

Please. chek it. ;)

from pragha.

maybe it works but you lose all changes in preferences

Yup.

from pragha.

Ok..

Well,
With the last change I think must be working correctly.

The only problem is that second side panel started always hidden.. Then fix it. 😉

Test it, and see if found any another problem.

from pragha.

Hi,
Now saving the secondary sidebar state in the last commit. No more regressions?

@rat4 ,you said:

it seems very unstable, including this crash

You have other problems?.
Please Pavel, also comments if you not agree with any of all the changes that i made before.

from pragha.

Recent commits and update of my system seem improved situation :-)

Still:

Log getting spammed with (pragha:22617): GLib-GObject-WARNING **: value "5" of type 'gint' is invalid or out of range for property 'file-type' of type 'gint'

Playback randomly stucks at some track, i.e. I press next, gui shows that next is playing but actually playing previous track

from pragha.

Log getting spammed with (pragha:22617): GLib-GObject-WARNING **: value "5" of type 'gint' is invalid or out of range for property 'file-type' of type 'gint'

Oh. Surely on MP4 files.. :S
I had forgotten this., If play the songs correctly, you can ignore this. You should analyze your library again.

Commit related: 2204c37#diff-8d5c241037aff809e039cb745c67233cL63

and 8b41c4e#diff-8d5c241037aff809e039cb745c67233cR57

Also i was thinking remove file types partially: 2b74e35#diff-816ed8065970a277b605f357f97f62e5R622

What you think?
Still need to add a dialog that you must update the library.

Playback randomly stucks at some track, i.e. I press next, gui shows that next is playing but actually playing previous track

I've experienced. Very sporadically but see this. However, coming from previous versions since PraghaPlaylist convertion.

from pragha.

@matiasdelellis I have one error, I don't think its Pragha's fault at all just a library issue on my machine. Wondered if you had any insight on how to get more information: Error playing current track. Reason: GStreamer encountered a general stream error.

from pragha.

@matiasdelellis rescan helped, probably you could keep compatibility though

@TingPing try GST_DEBUG
https://developer.gnome.org/gstreamer/stable/gst-running.html

from pragha.

I only write to tell them that with the new version, you have to update the library again. Basically, I returned back the changes over file_fype but change it again. (Now representing the foreign keys of mimetype). But is prepared to automatically update the library from 1.2 or .1.3.0. ;)

from pragha.

Just updated from d1f85b5 to 4ddfa1b and something went wrong. It
doesn't add any track to the current playlist with error
(pragha:25171): pragha-CRITICAL **: Track with location id : 314 not found in DB
After manual rescan all works fine.

from pragha.

Hi,
d1f85b5 still includes the changes that are not compatible..

Only in this commit 974557e, returned back the database cchanges, and here a52f7ef made compatible with 1.2 and 1.3.0.

It fails with those who were using the git version. They have to fully update the library. Would have to add a warning about it.

from pragha.

Well, if it affects only some git snapshots, it's not a big deal.

from pragha.