The header moved location in libcdio-paranoia-0.90 (and correction patch from upstream!) about pragha HOT 33 CLOSED

Hi,
As always .. thank you very much!.

Tomorrow see it!-)

Any idea if this bug fixed?
#4

from pragha.

Issue 4 seems to be fixed at least in combination of using Pragha 1.1.1 and libcdio-paranoia-0.90.

from pragha.

Pragha in fedora was recompile with libparanoia 0.90 without any change.

http://koji.fedoraproject.org/koji/buildinfo?buildID=376944

I really need the change?

from pragha.

Yes, because fedora is just temporarily installing to both cdio/cdda.h and cdio/paranoia/cdda.h and same for paranoia.h to allow builds to complete without issues
I went the hard road and decided not to do such temporary duplication and fix the dependencies instead
And we are in agreement with the Fedora maintainer as you can see in the gnome bug earlier I referenced

So if you want pragha to compile anywhere else than Fedora...

from pragha.

Yes, because fedora is just temporarily installing to both cdio/cdda.h and cdio/paranoia/cdda.h and same for paranoia.h to allow builds to complete without issues

Ok. Had searched, but not found information.

So if you want pragha to compile anywhere else than Fedora...

Haha. Obviously. In a moment fix it. ;)

Regards.

from pragha.

Please ssuominengentoo, Test last commit in git.

Regards,
Matias.

from pragha.

Hi, I've looked at it and unfortunately it could not work. The DEVS is exported to config.h which is in turn included from pragha.h but after cdda.h which uses the HAVE_PARANOIA_NEW_INCLUDES macro defined in config.h .
I'm not sure, why the comment "Should be before config.h, libcdio 0.83 issue" resides in pragha.h, but on my system (Arch linux 3.7.5-1-ARCH x86_64) works everything fine with #include <config.h> before #include "cdda.h".

from pragha.

*#include <config.h> before #include "cdda.h".

from pragha.

HAVE_PARANOIA_NEW_INCLUDES macro defined in config.h .

Ohh.. You're right!. :S

Should be before config.h, libcdio 0.83 issue

See the issue #4
Basically because libcdio 0.83 export some vars/defines like PACKAGE and PACKAGE_VERSION, and provides many problems. (For example that pragha always show as version 0.83)
The way to fix is adding all cdio headers before config.h of pragha, and also add the header cdio/cdio_unconfig.h to remove the bad defines.Once removed Pragha can override these defines.

Will try later again.. I'm answering from my mother's computer. =)

Regards,
Matias.

from pragha.

p.s: Looks like it was fixed in 0.90, but need that it work for both versions!

from pragha.

I do not know.
I do not see how to work with libcdio 0.83 and 0.90.

When released libcdio 0.83 did shit!, and now back to them!. :@

Sorry .. I am annoyed..

from pragha.

Be bleeding edge and abandon support for libcdio 0.83 :-)
No, I'm just kidding. I have no idea what to do with that :-(

from pragha.

Come on, Issue #4 is really only cosmetics, it's fine to close it off as "Fixed in cdio 0.90"
However this Issue is the one that needs fixing and is not plain cosmetics
Just make the README or somesuch say "libcdio 0.90 is recommended, 0.83 required"

from pragha.

@matiasdelellis no libcdio no cry :3

from pragha.

Come on, Issue #4 is really only cosmetics, it's fine to close it off as "Fixed in cdio 0.90"

Yes!!. But still bothers me the stupidity that they did with 0.83. With 0.81 also worked properly.

Just make the README or somesuch say "libcdio 0.90 is recommended, 0.83 required"

Well.. Sorry @ssuominengentoo

I will do that, but in reverse..
Fedora 18 (The distibution that use), The future ubuntu 13.4 [1], and surely Debian still use 0.83. So, By now I will leave ready for 0.83, together with the required patches for 0.90 commented. Whoever that use 0.90, should uncomment this. Of course properly commented in README.

@rat4
Issue #47 ?? From this... practically planned for 1.1.3. ¿Also port cdda to musicbrainz? hahaha. =)

[1] http://packages.ubuntu.com/km/raring/libcdio-paranoia-dev

from pragha.

commented.. what? where as proper AC_CHECK_HEADER could be added and close the issue for good in very simple way
didn't realize this app was Fedora only, and even that without rawhide support :/

from pragha.

Any point of view was developed only for fedora!. Never!.

But.. Something that is not clarify..
Not is only a cosmetic error!. The database pragha 0.83 is incompatible with the 0.90 or newest. It also implies a problem with that!.

If I'm not mistaken, commenting pragha.h line 23, it works fine!. no? (TRY IT PLEASE) It's the only thing that should be clarified in the README!.

from pragha.

Attempt to generate the less possible problems. also try to keep the minimum dependencies!. I think it's more correct to help people trying to use a stable distibution. No regrets for distributions like Arch or Gentoo, I love them!. But if you're willing to install the latest packages, you have to be willing to fix these inconveniences. I usually do too!.
0.90 adds something truly revolutionary? I can not find it. So.. I will force someone to install it? (Implying recompile all packages that depend on it).

I not want create any conflict. Sorry if I offended or something.
Regards.

from pragha.

Please..
Celeting line 23 is working?
Will release Pragha 1.1.2 the weekend. I promise that the next release will depend on 0.90.

from pragha.

Yes, commenting the line 23 in pragha.h works for me (Arch Linux 3.7.5 x86_64; libcdio 0.90).

from pragha.

Ok.
Thank you very much!. ;)

from pragha.

And now I have a problem in openSUSE.

[    7s] checking cdio/paranoia/cdda.h usability... no
[    7s] checking cdio/paranoia/cdda.h presence... no
[    7s] checking for cdio/paranoia/cdda.h... no

cdda.h is installed in cdio/

from pragha.

libcdio-paranoia-0.90? or 0.83?
Where I can see the opensuse packages? to see who made..

from pragha.

libcdio-paranoia git snapshot 4c905cc1aa (Mar 18, 2012).

https://build.opensuse.org/package/show?project=multimedia%3Alibs&package=libcdio-paranoia

from pragha.

opensuse needs to update their libcdio-paranoia, that snapshot is very old, older than 0.90, older than 0.83, ...

from pragha.

No. It is 0.84. From the build log:

[    7s] checking pkg-config is at least version 0.9.0... yes
[    7s] checking for libcdio_paranoia >= 0.80... 10.2+0.84
[    7s] checking LIBCDIO_PARANOIA_CFLAGS...  
[    7s] checking LIBCDIO_PARANOIA_LIBS... -lcdio_paranoia -lcdio_cdda -lcdio  

from pragha.

Nothing?
I'm downloading opensuse to try .. (Excuse to return to give him a chance.. jaja.)

from pragha.

Hi,
I'm here on a live usb of openSUSE 12.2 Kde.

Effectively is an older version of libdio, with some patches..
The messages that you show, only inform that no has 0.90. But compiles perfectly I am listening music in Pragha now.
It shows some other error?

EDIT: zypper update libcdio*, clarify that all packages are updated.

p.s: Nobody cares, but like always .. I love and hate opensuse!.

from pragha.

Yes. It compiles well and no other errors.

from pragha.

Ok. =)

from pragha.

I just added version 1.1.2 to Gentoo's Portage and noticed it doesn't work out-of-box with the new header location because src/cdda.h never includes config.h so HAVE_PARANOIA_NEW_INCLUDES is never set

from pragha.

Fail in line 22?? Coment 22, 23, 24.

from pragha.

You can just ./configure CPPFLAGS="-DHAVE_PARANOIA_NEW_INCLUDES" to make it compile, no need to comment out anything, like said, it's just missing the config.h include to get the define from in src/cdda.h

from pragha.