Comments (3)
I'm not sure if that scenario should be supported. If you are telling DSC to configure an application pool to run as a specific user, shouldn't you be required to also give DSC the username and password? If the App Pool didn't exist and you applied a DSC configuration where the identity type was 'SpecificUser', but without setting a username or password, DSC would be producing a broken system.
Even before your proposed changes, this resource's code around the pool identity looks a bit iffy to me.
I think a cleaner solution might be to make the identity type parameter completely optional (removing its current default setting), and just ignore those settings if IdentityType is set to $null (only applying a default value if it has to create a new pool).
Making that change would require an update to existing configuration scripts, though, if they were previously assuming that an unspecified value for IdentityType would default to ApplicationPoolIdentity.
from dsc.
I was about to say the same, but Dave beat me to it.
from dsc.
I did want to add though, thank you for offering to contribute back. I do appreciate the offer.
from dsc.
Related Issues (20)
- DSCBuild: Allow resource modules to specify their own build scripts HOT 2
- DscBuild: Restore state of Program Files directory on failed build HOT 6
- Add tests for DscBuild HOT 1
- Resolve-DscConfigurationProperty and Services vs node HOT 4
- Modules in DSC_Resorces cant be used to manage machine running invoke-DSCBuild. HOT 11
- Command conflicts HOT 1
- Get-DscConfigurationData filtering behavior HOT 1
- DSC Resource HOT 5
- cSmbshare Test-TargetResource FIX HOT 1
- ValidateSet can not be used for Arrays, PSCredentials, and Hashtable HOT 2
- How to get Credentials into a Configuration HOT 2
- Documentation for DSC tooling HOT 4
- New Resources for ElasticSearch, NSSM, 7zip and JRE HOT 15
- DSC resources for Team Foundation Server HOT 7
- Update credential encryption code
- Modify New-DscResourceFromModule to accept new parameters HOT 1
- Break up cDscDiagnostics into individual scripts HOT 4
- Add-DscEncryptedPassword functionality HOT 4
- DSC Resource PSHOrg_cADGroup to cActive Directory HOT 6
- building with Jenkins HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dsc.