Code Monkey home page Code Monkey logo

Comments (3)

dlwyatt avatar dlwyatt commented on August 12, 2024

I'm not sure if that scenario should be supported. If you are telling DSC to configure an application pool to run as a specific user, shouldn't you be required to also give DSC the username and password? If the App Pool didn't exist and you applied a DSC configuration where the identity type was 'SpecificUser', but without setting a username or password, DSC would be producing a broken system.

Even before your proposed changes, this resource's code around the pool identity looks a bit iffy to me.

I think a cleaner solution might be to make the identity type parameter completely optional (removing its current default setting), and just ignore those settings if IdentityType is set to $null (only applying a default value if it has to create a new pool).

Making that change would require an update to existing configuration scripts, though, if they were previously assuming that an unspecified value for IdentityType would default to ApplicationPoolIdentity.

from dsc.

smurawski avatar smurawski commented on August 12, 2024

I was about to say the same, but Dave beat me to it.

from dsc.

smurawski avatar smurawski commented on August 12, 2024

I did want to add though, thank you for offering to contribute back. I do appreciate the offer.

from dsc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.