Code Monkey home page Code Monkey logo

Comments (4)

PlagueHO avatar PlagueHO commented on July 30, 2024

Just a few thoughts on this:

Would this mean that any MOF's that are encoded in UTF8 are actually incorrect and should be re-encoded in ANSI? Most DSC repos presumably all have UTF8 encoded MOF files currently. If this is the case it might be good to create a script that updates all the MOF files for all repos in one go.

Also, the current test checks ALL files are not unicode encoded. Therefore I think the test would need to be split in two:

  1. Test MOFs are ANSI.
  2. Test all other text files are UTF-8.

A new Fixer would also need to be added to Meta.Fixers.ps1 - ConvertTo-ANSI().

from dscresource.tests.

vors avatar vors commented on July 30, 2024

ANSI is equal to UTF-8 on the 0-127 bytes (because it uses 1 byte to represent this values). So I don't see the problem.

I think there is a confusion introduced by the fact that PowerShell use Unicode as alias to UTF-16 encoding (2 bytes to represent all values). Unicode is not a particular encoding, but a character set. Here is a great and fun overview http://www.joelonsoftware.com/articles/Unicode.html .

from dscresource.tests.

PlagueHO avatar PlagueHO commented on July 30, 2024

Cool, thanks @vors - great article. I now realize my questions were a bit silly 😄

from dscresource.tests.

vors avatar vors commented on July 30, 2024

Synced offline with Travis, I didn't realize that xDscResourceDesigner ask to convert mof to UTF-16 (but it also supports ANSI). So we have this loop that Meta tests ask to convert to UTF-8 to make Git happy and xDscResourceDesigner tests ask to convert to UTF-16 and people have blocking PRs because of it. Thanks @TravisEz13 for taking actions!

from dscresource.tests.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.